Prepare THNN/THCUNN for first class scalars. #10023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I previous did some transformations, e.g. _nDimension,_dim -> nDimensionLegacyAll, nDimension -> nDimensionLegacyNoScalars. But this didn't touch dim(), which needs to be updated to support scalars. Instead of doing an (ugly) move, I audited the call sites and updated the cases that could be size 1.
gchanan
requested review from
apaszke,
colesbury,
ezyang,
soumith and
zdevito
as code owners
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pytorchbot retest this please. |
cpuhrsch
reviewed
Jul 30, 2018
| @@ -4,17 +4,17 @@ | |||
|
|
|||
| static bool THNN_(checkInput)(THCTensor* t) | |||
| { | |||
| return !t->is_empty() && THTensor_nDimensionLegacyAll(t) == 2 && t->size(1) == 3; | |||
| return !t->is_empty() && t->dim() == 2 && t->size(1) == 3; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
cpuhrsch
reviewed
Jul 30, 2018
| } | ||
|
|
||
| static bool THNN_(checkSize1D)(THCTensor* t, int64_t size0) | ||
| { | ||
| return !t->is_empty() && THTensor_nDimensionLegacyAll(t) == 1 && t->size(0) == size0; | ||
| return !t->is_empty() && THTensor_nDimensionLegacyNoScalars(t) == 1 && THTensor_sizeLegacyNoScalars(t, 0) == size0; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
cpuhrsch
approved these changes
Jul 30, 2018
|
@pytorchbot retest this please. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 31, 2018
Summary: I previous did some transformations, e.g. _nDimension,_dim -> nDimensionLegacyAll, nDimension -> nDimensionLegacyNoScalars. But this didn't touch dim(), which needs to be updated to support scalars. Instead of doing an (ugly) move, I audited the call sites and updated the cases that could be size 1. Pull Request resolved: pytorch/pytorch#10023 Differential Revision: D9068996 Pulled By: gchanan fbshipit-source-id: c63820767dd1496e908a5a96c34968482193f2c5
gchanan
added a commit
to gchanan/pytorch
that referenced
this pull request
Jul 31, 2018
Summary: I previous did some transformations, e.g. _nDimension,_dim -> nDimensionLegacyAll, nDimension -> nDimensionLegacyNoScalars. But this didn't touch dim(), which needs to be updated to support scalars. Instead of doing an (ugly) move, I audited the call sites and updated the cases that could be size 1. Pull Request resolved: pytorch#10023 Differential Revision: D9068996 Pulled By: gchanan fbshipit-source-id: c63820767dd1496e908a5a96c34968482193f2c5
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: I previous did some transformations, e.g. _nDimension,_dim -> nDimensionLegacyAll, nDimension -> nDimensionLegacyNoScalars. But this didn't touch dim(), which needs to be updated to support scalars. Instead of doing an (ugly) move, I audited the call sites and updated the cases that could be size 1. Pull Request resolved: pytorch#10023 Differential Revision: D9068996 Pulled By: gchanan fbshipit-source-id: c63820767dd1496e908a5a96c34968482193f2c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previous did some transformations, e.g. _nDimension,_dim -> nDimensionLegacyAll, nDimension -> nDimensionLegacyNoScalars.
But this didn't touch dim(), which needs to be updated to support scalars. Instead of doing an (ugly) move, I audited the call sites and updated the cases that could be size 1.