Kill Tensor::shares_data #10217
Closed
Kill Tensor::shares_data #10217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It's only used in debug printing and is not that reliable anyway. If we want to implement it later - we should do it proper accounting for shared storages. Differential Revision: D9155685 fbshipit-source-id: f75dad1da9374da9f39e487abdc8986ea29e00fe
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10217 It's only used in debug printing and is not that reliable anyway. If we want to implement it later - we should do it proper accounting for shared storages. Reviewed By: jerryzh168 Differential Revision: D9155685 fbshipit-source-id: 48320d41a0c4155645f3ba622ef88730a4567895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It's only used in debug printing and is not that reliable anyway. If we want to implement it later - we should do it proper accounting for shared storages.
Differential Revision: D9155685