[unified build] More fixes for hidden visibility #10624
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orionr
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
soumith
approved these changes
Aug 17, 2018
orionr
force-pushed
the
hidden-visibility
branch
from
5f89dee to
4618d76
Compare
|
Removed visibility change in CMakeLists.txt so we can see if these all pass. If so, I'll land and keep debugging the remaining issues on a separate PR. |
orionr
changed the title
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Re-run of the failed test succeeded at https://ci.pytorch.org/jenkins/job/caffe2-builds/job/py2-cuda9.0-cudnn7-aten-ubuntu16.04-trigger-test/10671/ |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 21, 2018
Summary: Let's run CI tests to see what fails given the changes that just landed in pytorch/pytorch#10624 cc mingzhe09088 ezyang Yangqing Pull Request resolved: pytorch/pytorch#10692 Reviewed By: mingzhe09088 Differential Revision: D9423617 Pulled By: orionr fbshipit-source-id: 3bda1f118d13f8dd8e823727c93167cae747d8cf
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Some more `ATEN_API` additions for hidden visibility. Running CI tests to see what fails to link. cc Yangqing mingzhe09088 ezyang Pull Request resolved: pytorch#10624 Reviewed By: mingzhe09088 Differential Revision: D9392728 Pulled By: orionr fbshipit-source-id: e0f0861496b12c9a4e40c10b6e0c9e0df18e8726
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Let's run CI tests to see what fails given the changes that just landed in pytorch#10624 cc mingzhe09088 ezyang Yangqing Pull Request resolved: pytorch#10692 Reviewed By: mingzhe09088 Differential Revision: D9423617 Pulled By: orionr fbshipit-source-id: 3bda1f118d13f8dd8e823727c93167cae747d8cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more
ATEN_APIadditions for hidden visibility.Running CI tests to see what fails to link.
cc @Yangqing @mingzhe09088 @ezyang