[Reland2] Update NVTX to NVTX3 #109843
Closed
[Reland2] Update NVTX to NVTX3 #109843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
requested review from
jeffdaily,
jithunnair-amd and
aaronenyeshi
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109843
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 3 Unrelated FailuresAs of commit 8b303bd with merge base 0a25666 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cyyever
force-pushed
the
nvtx3_fix2
branch
4 times, most recently
from
b2eaaf7 to
d260ed6
Compare
|
@izaitsevfb This PR combines your changes in #107497 and more cleanups. And I chose to include 'nvtx3/XXX' to avoid confusion and linking issues between old and newer versions of NVTX. |
cyyever
changed the title
|
@pytorchbot label "topic: not user facing" |
cyyever
force-pushed
the
nvtx3_fix2
branch
2 times, most recently
from
f9d1d49 to
eebcc4b
Compare
|
@pytorchbot label ciflow/binaries |
pytorch-bot
bot
added
the
ciflow/binaries
cyyever
force-pushed
the
nvtx3_fix2
branch
4 times, most recently
from
65f5805 to
52c1190
Compare
|
Windows test hosts must install NVTX3 before we can continue. I proposed a PR at pytorch/builder#1547 |
|
@pytorchbot rebase |
cyyever
force-pushed
the
nvtx3_fix2
branch
6 times, most recently
from
472ac1b to
823cee6
Compare
Co-authored-by: Ivan Zaitsev <[email protected]>
|
@pytorchmergebot merge -f "Rocm 6.0 was removed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Another attempt to update NVTX to NVTX3. We now avoid changing NVTX header inclusion of existing code. The advantage of NVTX3 over NVTX is that it is a header-only library so that linking with NVTX3 can greatly simplify our CMake and other building scripts for finding libraries in user environments. In addition, NVTX are indeed still present in the latest CUDA versions, but they're no longer a compiled library: It's now a header-only library. That's why there isn't a .lib file anymore. Pull Request resolved: #109843 Approved by: https://github.com/peterbell10, https://github.com/eqy Co-authored-by: Ivan Zaitsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to update NVTX to NVTX3. We now avoid changing NVTX header inclusion of existing code. The advantage of NVTX3 over NVTX is that it is a header-only library so that linking with NVTX3 can greatly simplify our CMake and other building scripts for finding libraries in user environments. In addition, NVTX are indeed still present in the latest CUDA versions, but they're no longer a compiled library: It's now a header-only library. That's why there isn't a .lib file anymore.
cc @malfet @seemethere @izaitsevfb @peterbell10