Skip to content

Support import of nn.RNNCellBase in __all__ #10992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

zuoxingdong
Copy link
Contributor

No description provided.

@soumith
Copy link
Member

soumith commented Aug 29, 2018

Lint is failing, and you need to fix that. See https://travis-ci.org/pytorch/pytorch/jobs/421948810

@zuoxingdong
Copy link
Contributor Author

@soumith Now it is fixed, however, the clang build is failed, is it expected ?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zuoxingdong zuoxingdong deleted the patch-2 branch August 31, 2018 09:33
PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Sep 11, 2018
Summary: Pull Request resolved: pytorch#10992

Differential Revision: D9572005

Pulled By: soumith

fbshipit-source-id: 26b546830b6a25a4f7ba6f825cd888d678233a97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants