Move TensorOptions to ATen/core #11147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9562197 Differential Version: 56442349
Differential Revision: D9562312 Differential Version: 56443146
Differential Revision: D9562312 Differential Version: 56443358
Differential Revision: D9562467 Differential Version: 5644387
Differential Revision: D9562467 Differential Version: 56445436
Differential Revision: D9562312 Differential Version: 56445886
Differential Revision: D9562467 Differential Version: 56447016
Differential Revision: D9562467 Differential Version: 56447216
Differential Revision: D9564206 Differential Version: 5645296
Differential Revision: D9562312 Differential Version: 56453321
Differential Revision: D9564516 Differential Version: 56455053
Differential Revision: D9562467 Differential Version: 56473044
Differential Revision: D9562197 Differential Version: 56473286
Differential Revision: D9578398 Differential Version: 56517363
Differential Revision: D9578399 Differential Version: 56517362
Differential Revision: D9578734 Differential Version: 56519039
Differential Revision: D9578734 Differential Version: 56520207
Differential Revision: D9578734 Differential Version: 56526151
Differential Revision: D9581560 Differential Version: 56526196
Differential Revision: D9578734 Differential Version: 56530959
Differential Revision: D9581560 Differential Version: 56532263
Differential Revision: D9581560 Differential Version: 56532377
Differential Revision: D9581560 Differential Version: 56535272
Differential Revision: D9583630 Differential Version: 56536211
Differential Revision: D9583699 Differential Version: 56536805
Differential Revision: D9562197 Differential Version: 56537293
Differential Revision: D9581560 Differential Version: 56537640
Differential Revision: D9581560 Differential Version: 5653849
Differential Revision: D9583630 Differential Version: 56538643
Differential Revision: D9583699 Differential Version: 56539029
Differential Revision: D9613897 Differential Version: 56672441
Differential Revision: D9562467 Differential Version: 56672440
Differential Revision: D9564206 Differential Version: 56672438
Differential Revision: D9564516 Differential Version: 56672443
Differential Revision: D9614321 Differential Version: 56672442
gchanan
approved these changes
Aug 31, 2018
|
looks like this crossed with the Type change somewhere. |
|
excite |
|
Yes, it seems I still have to get rid of the Type constructor. Should be easier after #11013 lands |
Differential Revision: D9614321 Differential Version: 56766580
ezyang
requested review from
anderspapitto,
bddppq,
dzhulgakov,
fmassa,
houseroad,
jamesr66a,
pietern,
smessmer,
teng-li and
Yangqing
as code owners
Differential Revision: D9614321 Differential Version: 56769049
Differential Revision: D9614321 Differential Version: 56803229
Differential Revision: D9614321 Differential Version: 56805604
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 4, 2018
Summary: Pull Request resolved: pytorch/pytorch#11147 Reviewed By: gchanan Differential Revision: D9614321 fbshipit-source-id: 618cb342eb7c52181425f6bb9c17b9ecdb87a394
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11147 Reviewed By: gchanan Differential Revision: D9614321 fbshipit-source-id: 618cb342eb7c52181425f6bb9c17b9ecdb87a394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move TensorOptions to ATen/core
Differential Revision: D9614321
Stacked on #11189