Skip to content

Conversation

ngimel
Copy link
Collaborator

@ngimel ngimel commented Aug 31, 2018

Fixes one of #11118 issues.

@zou3519 zou3519 added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 31, 2018
test/test_jit.py Outdated
y = torch.randn(4, 4, dtype=torch.float, device='cuda')

ge = self.checkTrace(f, (x, y))
self.assertExpectedGraph(ge.graph_for(x,y))

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@@ -925,7 +925,14 @@ struct CUDAFusedKernel : public FusedKernel {
TORCH_NVRTC_CHECK(nvrtcGetPTXSize(program, &ptx_size));
ptx.resize(ptx_size);
TORCH_NVRTC_CHECK(nvrtcGetPTX(program, ptx.data()));

//need an active context for cuModuleLoadData

This comment was marked as off-topic.

This comment was marked as off-topic.

@mruberry
Copy link
Collaborator

mruberry commented Sep 4, 2018

I can also rebase just fine, and the split PR already has one merge conflict. Order not important.

Copy link
Contributor

@apaszke apaszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait since @mruberry's patch is going to land soon

@t-vi t-vi mentioned this pull request Sep 12, 2018
@t-vi
Copy link
Collaborator

t-vi commented Sep 15, 2018

#10981 has been merged. :)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2018
Summary:
This patch adds fused forward and backward for clamp to the jit.
This is one item of #11118 . If it's OK, I'd be happy to also add some more of #11118 .

The patch depends on #11150 , which I merged into master as a base. I'll rebase it when that or #10981 is merged.

This is first serious jit patch, thank you, ngimel and the others for their guidance. All errors are my own.
Pull Request resolved: #11574

Differential Revision: D9943090

Pulled By: apaszke

fbshipit-source-id: c40954b8c28c374baab8d3bd89acc9250580dc67
@ngimel ngimel deleted the jit_fixes branch September 23, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oncall: jit Add this issue/PR to JIT oncall triage queue open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants