Expunge (transitive) caffe2_pb2 dependency from tensor_impl.h from context_base.h #11818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D9924348 Differential Version: 58210781
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 19, 2018
…ntext_base.h (#11818) Summary: Pull Request resolved: pytorch/pytorch#11818 To do this, I have to move the static context registry into ATen/core. I take the opportunity to convert it into an unordered_map. Reviewed By: Yangqing Differential Revision: D9924348 fbshipit-source-id: 8d92b9e8b4246ce608eba24ecef7ad5f8b9b6582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11818 Expunge (transitive) caffe2_pb2 dependency from tensor_impl.h from context_base.h 💛
To do this, I have to move the static context registry into ATen/core.
I take the opportunity to convert it into an unordered_map.
Differential Revision: D9924348