Skip to content

Prepend a "const" to a for loop in printPyObject. #11857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Sep 19, 2018

As pytuple should be a constant type (since obj is constant), potential errors would occur without
this const decorator, e.g., when compiling against PyPy. Although PyPy is not supported yet, it
would still be useful if we remove this compilation issue (out of very few numbers of compilation
issues) to allow hackers playing with them.

As pytuple should be a constant type (since obj is constant), potential errors would occur without
this const decorator, e.g., when compiling against PyPy. Although PyPy is not supported yet, it
would still be useful if we remove this compilation issue (out of very few numbers of compilation
issues) to allow hackers playing with them.
@pytorchbot pytorchbot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 19, 2018
@lopuhin
Copy link
Contributor

lopuhin commented Sep 23, 2018

PyPy support would be awesome! Looks like the only build failure is this stalled build https://travis-ci.org/pytorch/pytorch/jobs/430446228 (travis issue)

@xuhdev xuhdev closed this Sep 23, 2018
@xuhdev xuhdev reopened this Sep 23, 2018
@xuhdev xuhdev closed this Sep 23, 2018
@xuhdev xuhdev reopened this Sep 23, 2018
@xuhdev
Copy link
Collaborator Author

xuhdev commented Sep 23, 2018

@lopuhin Now all tests passed! Can you review again?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lopuhin lopuhin mentioned this pull request Mar 9, 2019
@xuhdev xuhdev deleted the pytuple-const branch May 24, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oncall: jit Add this issue/PR to JIT oncall triage queue open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants