Skip to content

Add support for blackwell codegen #141724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Nov 27, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141724

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bc4489f with merge base 42ab612 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

drisspg added a commit that referenced this pull request Nov 27, 2024
ghstack-source-id: 0a4bd12
Pull Request resolved: #141724
@drisspg drisspg requested a review from malfet November 27, 2024 21:49
@drisspg drisspg added the topic: not user facing topic category label Nov 27, 2024
[ghstack-poisoned]
drisspg added a commit that referenced this pull request Nov 28, 2024
ghstack-source-id: 828cf3d
Pull Request resolved: #141724
@Skylion007
Copy link
Collaborator

@drisspg Do we need to merge in #131493 to get the full benefits of this? I noticed some ptxas warning in the 12.6 builds which I suspect is from our old version of CUTLASS.

[ghstack-poisoned]
drisspg added a commit that referenced this pull request Nov 28, 2024
ghstack-source-id: 8b95fbf
Pull Request resolved: #141724
@drisspg
Copy link
Contributor Author

drisspg commented Nov 28, 2024

@Skylion007 This is just being forward looking, when the next gen hardware drops it will require new gen_code and if you try to pass that in today CUDA_ARCH_LIST you get an error since we dont correctly regex match the string

[ghstack-poisoned]
drisspg added a commit that referenced this pull request Nov 28, 2024
ghstack-source-id: f9bead7
Pull Request resolved: #141724
@Skylion007
Copy link
Collaborator

True @drisspg Is there an issue to track for blackwell support?

[ghstack-poisoned]
drisspg added a commit that referenced this pull request Dec 3, 2024
ghstack-source-id: dcf8457
Pull Request resolved: #141724
@drisspg drisspg added the module: cuda Related to torch.cuda, and CUDA support in general label Dec 3, 2024
@drisspg
Copy link
Contributor Author

drisspg commented Dec 3, 2024

@ptrblck Are there any tracking issues for Blackwell? I imagine some other things will show up as software/hardware gets released

@drisspg
Copy link
Contributor Author

drisspg commented Dec 3, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 3, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@drisspg
Copy link
Contributor Author

drisspg commented Dec 3, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: cuda Related to torch.cuda, and CUDA support in general topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants