Support `next(iterator, default)` #159483

guilhermeleobas · 2025-07-30T15:52:15Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @mlazos

[ghstack-poisoned]

pytorch-bot · 2025-07-30T15:52:19Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159483

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e1a1aad with merge base e299926 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
vision_maskrcnn

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 3ad9c3d Pull-Request: #159483

[ghstack-poisoned]

ghstack-source-id: a66afda Pull-Request: #159483

mlazos

Thanks, this was way simpler than I thought!

[ghstack-poisoned]

ghstack-source-id: a8e62e3 Pull-Request: #159483

[ghstack-poisoned]

guilhermeleobas · 2025-08-15T00:25:46Z

@pytorchbot merge

pytorchmergebot · 2025-08-15T00:27:39Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-08-15T00:38:21Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / Link checks / lint-urls / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

[ghstack-poisoned]

guilhermeleobas · 2025-08-15T18:26:44Z

@pytorchbot merge

pytorchmergebot · 2025-08-15T18:28:49Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

#159902) Pull Request resolved: #159902 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483

…159864) Pull Request resolved: #159864 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902

…ts (#159865) Changes: (1) Replace UserDefinedSetVariable by UserDefinedObjectVariable in all binop calls Test plan: (1) The three tests from CPython `test_collections.py` ensures that Dynamo can trace through a dunder method (e.g. __add__, __ixor__, etc) defined in a user defined class Pull Request resolved: #159865 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902, #159864

Pull Request resolved: #159367 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902, #159864, #159865

ghstack-source-id: fa914e8 Pull-Request: pytorch/pytorch#159483

Pull Request resolved: pytorch#159483 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368

pytorch#159902) Pull Request resolved: pytorch#159902 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483

…ytorch#159864) Pull Request resolved: pytorch#159864 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902

…ts (pytorch#159865) Changes: (1) Replace UserDefinedSetVariable by UserDefinedObjectVariable in all binop calls Test plan: (1) The three tests from CPython `test_collections.py` ensures that Dynamo can trace through a dunder method (e.g. __add__, __ixor__, etc) defined in a user defined class Pull Request resolved: pytorch#159865 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864

Pull Request resolved: pytorch#159367 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864, pytorch#159865

Pull Request resolved: pytorch#159483 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368

pytorch#159902) Pull Request resolved: pytorch#159902 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483

…ytorch#159864) Pull Request resolved: pytorch#159864 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902

…ts (pytorch#159865) Changes: (1) Replace UserDefinedSetVariable by UserDefinedObjectVariable in all binop calls Test plan: (1) The three tests from CPython `test_collections.py` ensures that Dynamo can trace through a dunder method (e.g. __add__, __ixor__, etc) defined in a user defined class Pull Request resolved: pytorch#159865 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864

Pull Request resolved: pytorch#159367 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864, pytorch#159865

Update

0b5528d

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Jul 30, 2025

Support next(iterator, default)

56213aa

ghstack-source-id: 3ad9c3d Pull-Request: #159483

pytorch-bot bot added ciflow/inductor module: dynamo labels Jul 30, 2025

guilhermeleobas added the release notes: dynamo label Jul 30, 2025

guilhermeleobas marked this pull request as ready for review July 30, 2025 16:06

pytorchbot added the open source label Jul 30, 2025

Update

761e67d

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Aug 1, 2025

Support next(iterator, default)

3ec27e9

ghstack-source-id: a66afda Pull-Request: #159483

This was referenced Aug 1, 2025

Enable trace through the collections module #159365

Closed

Change mutation type of MutableMappingVariable to AttributeMutationNew #159366

Closed

Fixes for collections.NamedTuple #159367

Closed

Fixes for collections.Counter #159368

Closed

mlazos approved these changes Aug 2, 2025

View reviewed changes

Update

dfafce6

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Aug 4, 2025

Support next(iterator, default)

ccbce7c

ghstack-source-id: a8e62e3 Pull-Request: #159483

This was referenced Aug 5, 2025

Implement list(UserDefinedObject) via force_unpack_var_sequence #159864

Closed

[collections.abc] Ensure that binop calls works with UserDefinedObjects #159865

Closed

Update

7f8b314

[ghstack-poisoned]

guilhermeleobas mentioned this pull request Aug 5, 2025

Wrap class definitions in set_fullgraph(False) in test_collections #159902

Closed

guilhermeleobas added 6 commits August 13, 2025 22:02

Update

5fd0678

[ghstack-poisoned]

Update

f9eca81

[ghstack-poisoned]

Update

f6602a5

[ghstack-poisoned]

Update

2f44712

[ghstack-poisoned]

Update

e4a25a9

[ghstack-poisoned]

Update

887c177

[ghstack-poisoned]

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 15, 2025

pytorchmergebot added the merging label Aug 15, 2025

pytorchmergebot removed the merging label Aug 15, 2025

Update

e1a1aad

[ghstack-poisoned]

pytorchmergebot added the merging label Aug 15, 2025

pytorchmergebot added the Merged label Aug 15, 2025

pytorchmergebot closed this in b78968b Aug 15, 2025

pytorchmergebot removed the merging label Aug 15, 2025

pytorchmergebot pushed a commit that referenced this pull request Aug 18, 2025

Fixes for collections.NamedTuple (#159367)

c6333f7

Pull Request resolved: #159367 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902, #159864, #159865

khanaks-nv pushed a commit to khanaks-nv/pytorch that referenced this pull request Aug 19, 2025

Support next(iterator, default)

df767a6

ghstack-source-id: fa914e8 Pull-Request: pytorch/pytorch#159483

github-actions bot deleted the gh/guilhermeleobas/220/head branch September 15, 2025 02:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support `next(iterator, default)` #159483

Support `next(iterator, default)` #159483

Uh oh!

guilhermeleobas commented Jul 30, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

mlazos left a comment

Uh oh!

guilhermeleobas commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

guilhermeleobas commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

Uh oh!

Support next(iterator, default) #159483

Support next(iterator, default) #159483

Uh oh!

Conversation

guilhermeleobas commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159483

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

mlazos left a comment

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Merge started

Uh oh!

pytorchmergebot commented Aug 15, 2025

Merge failed

Uh oh!

guilhermeleobas commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Merge started

Uh oh!

Uh oh!

Support `next(iterator, default)` #159483

Support `next(iterator, default)` #159483

guilhermeleobas commented Jul 30, 2025 •

edited

Loading

pytorch-bot bot commented Jul 30, 2025 •

edited

Loading