Skip to content

[while_loop][autograd] support autograd_key of while_loop #160483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

[while_loop][autograd] support autograd_key of while_loop #160483

wants to merge 25 commits into from

Conversation

ydwu4
Copy link
Contributor

@ydwu4 ydwu4 commented Aug 13, 2025 •
edited
Loading

@ydwu4 ydwu4 requested a review from zou3519 as a code owner August 13, 2025 00:14
This was referenced Aug 12, 2025
Closed
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160483

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b7965b2 with merge base 7a83cf4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ydwu4 ydwu4 mentioned this pull request Aug 13, 2025
Open
ydwu4 added a commit that referenced this pull request Aug 13, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop_with_check…
7e922ff 
…point

ghstack-source-id: 710470d
Pull Request resolved: #160483
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop…
a48d6f4 
…_with_checkpoint"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
This was referenced Aug 14, 2025
Closed
Closed
Closed
Closed
ydwu4 added a commit that referenced this pull request Aug 14, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop_with_check…
dd60840 
…point

ghstack-source-id: dc457cb
Pull Request resolved: #160483
@ydwu4 ydwu4 added the topic: not user facing topic category label Aug 14, 2025
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop…
f9fcd47 
…_with_checkpoint"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
ydwu4 added a commit that referenced this pull request Aug 14, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop_with_check…
337a700 
…point

ghstack-source-id: b604c25
Pull Request resolved: #160483
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop…
73e4f7f 
…_with_checkpoint"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
ydwu4 added a commit that referenced this pull request Aug 15, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop_with_check…
85180db 
…point

ghstack-source-id: 8e5edc1
Pull Request resolved: #160483
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop…
e0d78b5 
…_with_checkpoint"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
ydwu4 added a commit that referenced this pull request Aug 16, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop_with_check…
fe1bc45 
…point

ghstack-source-id: bb396db
Pull Request resolved: #160483
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop…
028cc8f 
…_with_checkpoint"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
@ydwu4 ydwu4 mentioned this pull request Aug 25, 2025
Closed
ydwu4 added a commit that referenced this pull request Aug 25, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop_with_check…
ab99abd 
…point

ghstack-source-id: 2138bed
Pull Request resolved: #160483
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop…
a84ee3e 
…_with_checkpoint"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
ydwu4 added a commit that referenced this pull request Aug 25, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop_with_check…
4ba2251 
…point

ghstack-source-id: 4c579af
Pull Request resolved: #160483
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop…
73ec539 
…_with_checkpoint"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
ydwu4 added a commit that referenced this pull request Aug 26, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop_with_check…
1c586dd 
…point

ghstack-source-id: c9957e0
Pull Request resolved: #160483
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop"
0506660 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
ydwu4 added a commit that referenced this pull request Sep 5, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop
e8638b3 
ghstack-source-id: 48e9835
Pull Request resolved: #160483
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop"
376999e 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
ydwu4 added a commit that referenced this pull request Sep 5, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop
e7efb9e 
ghstack-source-id: 48e9835
Pull Request resolved: #160483
@ydwu4
Copy link
Contributor Author

ydwu4 commented Sep 6, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Sep 7, 2025

@pytorchbot revert -m 'Sorry for reverting your PR, but some trunk tests are failing either from this PR or the previous one in the stack' -c nosignal

inductor/test_control_flow.py::WhileLoopTests::test_while_loop_with_unbacked_symint_closure_device_cuda_dynamic_True_autograd_True GH job link HUD commit link

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Sep 7, 2025
@pytorchmergebot
Revert " [while_loop][autograd] support autograd_key of while_loop (#…
7a83cf4 
…160483)"

This reverts commit 2b8a839.

Reverted #160483 on behalf of https://github.com/huydhn due to Sorry for reverting your PR, but some trunk tests are failing either from this PR or the previous one in the stack ([comment](#160483 (comment)))
@pytorchmergebot
Copy link
Collaborator

@ydwu4 your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Sep 7, 2025
@ydwu4
Update on " [while_loop][autograd] support autograd_key of while_loop"
b7965b2 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
ydwu4 added a commit that referenced this pull request Sep 7, 2025
@ydwu4
[while_loop][autograd] support autograd_key of while_loop
bdfc9d0 
ghstack-source-id: 641e5a6
Pull Request resolved: #160483
@ydwu4
Copy link
Contributor Author

ydwu4 commented Sep 7, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

daisyden pushed a commit to daisyden/pytorch that referenced this pull request Sep 8, 2025
@ydwu4 @daisyden
[while_loop][autograd] support autograd_key of while_loop (pytorch#1…
2e2671c 
…60483)

Pull Request resolved: pytorch#160483
Approved by: https://github.com/zou3519
ghstack dependencies: pytorch#160548, pytorch#160467
daisyden pushed a commit to daisyden/pytorch that referenced this pull request Sep 8, 2025
@pytorchmergebot @daisyden
Revert " [while_loop][autograd] support autograd_key of while_loop (p…
12dac62 
…ytorch#160483)"

This reverts commit 2b8a839.

Reverted pytorch#160483 on behalf of https://github.com/huydhn due to Sorry for reverting your PR, but some trunk tests are failing either from this PR or the previous one in the stack ([comment](pytorch#160483 (comment)))
daisyden pushed a commit to daisyden/pytorch that referenced this pull request Sep 8, 2025
@ydwu4 @daisyden
[while_loop][autograd] support autograd_key of while_loop (pytorch#1…
ccb8a99 
…60483)

Pull Request resolved: pytorch#160483
Approved by: https://github.com/zou3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ydwu4 @pytorchmergebot @huydhn @zou3519