-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[OpenReg] Migrate Accelerator Document from source/notes into source/accelerator #161845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161845
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 30d3039 with merge base fca2601 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Starting merge as part of PR stack under #161903 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only minor comment on the introducing the follow up
FYI @svekars
This guide is a work in progress. For more details, please refer to the [roadmap](https://github.com/pytorch/pytorch/issues/158917). | ||
``` | ||
|
||
```{toctree} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the rendering, this doesn't really look like the next step if you want to read more. I think we should have a sentence to introduce it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comments.
This PR was triggered to be merged by this comment, so I will submit a new PR to fix the issue mentioned above.
Starting merge as part of PR stack under #161903 |
Starting merge as part of PR stack under #161947 |
As the title stated. Pull Request resolved: #161903 Approved by: https://github.com/ezyang ghstack dependencies: #161845
…61947) As the title stated. Pull Request resolved: #161947 Approved by: https://github.com/albanD ghstack dependencies: #161845, #161903
Is it just me or I can't find this page on the website? |
No, it hasn't been updated since August 13th. I reached out to @svekars about a week ago for help but didn't get a response. I'll dig deeper and see what's going on right now. |
Fix the issue describled by this [comment](#161845 (comment)) Pull Request resolved: #162046 Approved by: https://github.com/albanD
Hey @seemethere, sorry to bother you. I found the preview doc for Per PR can been updated as every PR, but the doc of main branch have not been updated for a long while, and I have checked all points I can think of generating python docs for PyTorch but can not find what the root cause is, all the workflow about docs are work as expected and no any error raised. |
Hey @seemethere @albanD @ezyang I throught I get the root cause possibly, the doc of main branch is triggered by pytorch/.github/workflows/nightly.yml Lines 3 to 5 in c238820
Prepare all required actions
Getting action download info
Download action repository 'seemethere/download-artifact-s3@v4' (SHA:1da556a7aa0a088e3153970611f6c432d58e80e6)
Download action repository 'actions/download-artifact@v4' (SHA:d3f86a106a0bac45b974a628896c90dbdf5c8093)
Run ./.github/actions/download-build-artifacts
Run seemethere/download-artifact-s3@v4
(node:45859) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.
Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
(Use `node --trace-warnings ...` to show where the warning was created)
Found 0 objects with prefix pytorch/pytorch/17599208654/linux-jammy-py3.9-gcc11/
Artifact download has finished successfully
Run unzip -o artifacts.zip
unzip: cannot find or open artifacts.zip, artifacts.zip.zip or artifacts.zip.ZIP. Who can I ask for help to fix it? Thank you very much. |
Thanks for looking into this. I wasn't expecting this build to be broken :o |
Stack from ghstack (oldest at bottom):
As the tile stated.
As the document grows, the content will become more and more, so in order to make it easier for users to read and easier for developers to maintain, we have split this file into several separate files and placed them in a dedicated directory called "accelerator".