Skip to content

Conversation

FFFrog
Copy link
Collaborator

@FFFrog FFFrog commented Aug 30, 2025

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161845

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 30d3039 with merge base fca2601 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #161903

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only minor comment on the introducing the follow up

FYI @svekars

This guide is a work in progress. For more details, please refer to the [roadmap](https://github.com/pytorch/pytorch/issues/158917).
```

```{toctree}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the rendering, this doesn't really look like the next step if you want to read more. I think we should have a sentence to introduce it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comments.

This PR was triggered to be merged by this comment, so I will submit a new PR to fix the issue mentioned above.

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #161903

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #161947

@albanD
Copy link
Collaborator

albanD commented Sep 9, 2025

Is it just me or I can't find this page on the website?

@FFFrog
Copy link
Collaborator Author

FFFrog commented Sep 10, 2025

Is it just me or I can't find this page on the website?

No, it hasn't been updated since August 13th. I reached out to @svekars about a week ago for help but didn't get a response. I'll dig deeper and see what's going on right now.

pytorchmergebot pushed a commit that referenced this pull request Sep 10, 2025
Fix the issue describled by this [comment](#161845 (comment))
Pull Request resolved: #162046
Approved by: https://github.com/albanD
@FFFrog
Copy link
Collaborator Author

FFFrog commented Sep 10, 2025

Hey @seemethere, sorry to bother you.

I found the preview doc for Per PR can been updated as every PR, but the doc of main branch have not been updated for a long while, and I have checked all points I can think of generating python docs for PyTorch but can not find what the root cause is, all the workflow about docs are work as expected and no any error raised.

@FFFrog
Copy link
Collaborator Author

FFFrog commented Sep 10, 2025

Hey @seemethere @albanD @ezyang

I throught I get the root cause possibly, the doc of main branch is triggered by schedule in this file

on:
schedule:
- cron: 0 0 * * *
, but the workflow have failed for a long while, but it is beyond my control and I can not fix it.

Prepare all required actions
Getting action download info
Download action repository 'seemethere/download-artifact-s3@v4' (SHA:1da556a7aa0a088e3153970611f6c432d58e80e6)
Download action repository 'actions/download-artifact@v4' (SHA:d3f86a106a0bac45b974a628896c90dbdf5c8093)
Run ./.github/actions/download-build-artifacts
Run seemethere/download-artifact-s3@v4
(node:45859) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
(Use `node --trace-warnings ...` to show where the warning was created)
Found 0 objects with prefix pytorch/pytorch/17599208654/linux-jammy-py3.9-gcc11/
Artifact download has finished successfully
Run unzip -o artifacts.zip
unzip:  cannot find or open artifacts.zip, artifacts.zip.zip or artifacts.zip.ZIP.

Who can I ask for help to fix it? Thank you very much.

@albanD
Copy link
Collaborator

albanD commented Sep 11, 2025

Thanks for looking into this. I wasn't expecting this build to be broken :o
The issue you opened is the right way to flag this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants