Align AT_FORALL macros with AT_DISPATCH macros. #23339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter.
pytorchbot
added
caffe2
module: cpu
This was referenced Jul 24, 2019
Closed
Closed
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter. Differential Revision: [D16467983](https://our.internmc.facebook.com/intern/diff/D16467983)
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter. Differential Revision: [D16467983](https://our.internmc.facebook.com/intern/diff/D16467983)
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter. Differential Revision: [D16467983](https://our.internmc.facebook.com/intern/diff/D16467983)
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter. Differential Revision: [D16467983](https://our.internmc.facebook.com/intern/diff/D16467983)
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter. Differential Revision: [D16467983](https://our.internmc.facebook.com/intern/diff/D16467983)
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter. Differential Revision: [D16467983](https://our.internmc.facebook.com/intern/diff/D16467983)
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter. Differential Revision: [D16467983](https://our.internmc.facebook.com/intern/diff/D16467983)
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter. Differential Revision: [D16467983](https://our.internmc.facebook.com/intern/diff/D16467983)
gchanan
added a commit
that referenced
this pull request
Aug 9, 2019
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. Still to come: get rid of the now-unused tag parameter. ghstack-source-id: f9b0fc1 Pull Request resolved: #23339
gchanan
changed the title
|
clang tidy failures are bogus. |
ezyang
approved these changes
Aug 12, 2019
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES. This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information, this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag. I verified via godbolt that in -O2 the Scalar.h changes generates identical code. Still to come: get rid of the now-unused tag parameter. Differential Revision: [D16467983](https://our.internmc.facebook.com/intern/diff/D16467983)
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 12, 2019
Summary: Pull Request resolved: pytorch/pytorch#23339 Test Plan: Imported from OSS Differential Revision: D16467983 Pulled By: gchanan fbshipit-source-id: 84a29a03d3ec9c6416cad254a9ff1005fdc6324f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
e.g. previously, AT_FORALL_SCALAR_TYPES consisted of different ScalarTypes than those dispatched from AT_DISPATCH_ALL_TYPES.
This also defines at::Scalar constructors a little differently; the FORALL macros no longer contain the tag information,
this is done internally to at::Scalar (otherwise, it made defining AND macros difficult, because the user had to provide the tag.
I verified via godbolt that in -O2 the Scalar.h changes generates identical code.
Still to come: get rid of the now-unused tag parameter.
Differential Revision: D16467983