Skip to content

[fix] at::view #23452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jul 26, 2019

Stack from ghstack:

accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: D16442756

accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
@pytorchbot pytorchbot added module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general module: internals Related to internal abstractions in c10 and ATen module: operators labels Jul 26, 2019
@jerryzh168 jerryzh168 mentioned this pull request Jul 26, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168 added a commit that referenced this pull request Jul 27, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: #23452
ghstack-source-id: 87295248

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
Copy link

@z-a-f z-a-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168 added a commit that referenced this pull request Jul 28, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: #23452
ghstack-source-id: 87306405

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168 added a commit that referenced this pull request Jul 29, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: #23452
ghstack-source-id: 87319193

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
@jerryzh168
Copy link
Contributor Author

@pytorchbot retest this please

accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168 added a commit that referenced this pull request Jul 29, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: #23452
ghstack-source-id: 87329201

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
@jerryzh168
Copy link
Contributor Author

@pytorchbot retest this please

@jerryzh168
Copy link
Contributor Author

@pytorchb retest this please

accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
@pytorchbot pytorchbot added the oncall: quantization Quantization support in PyTorch label Jul 29, 2019
jerryzh168 added a commit that referenced this pull request Jul 29, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: #23452
ghstack-source-id: 87373215

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168 added a commit that referenced this pull request Jul 30, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: #23452
ghstack-source-id: 87410859

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
accidently calls clone, but what we want is creating an empty tensor and set storage.

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168 added a commit that referenced this pull request Jul 30, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: #23452
ghstack-source-id: 87438096

Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
@zou3519 zou3519 deleted the gh/jerryzh168/18/head branch July 31, 2019 01:10
zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 31, 2019
Summary:
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: pytorch/pytorch#23452
ghstack-source-id: 87438096

Differential Revision: D16442756

fbshipit-source-id: 6d5663f82c9bd4e9de8fc846c52992477843af6a
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 775d7bd.

jerryzh168 added a commit to jerryzh168/pytorch that referenced this pull request Jul 31, 2019
Summary:
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: pytorch#23452
ghstack-source-id: 87438096

Differential Revision: D16442756

fbshipit-source-id: 6d5663f82c9bd4e9de8fc846c52992477843af6a
@jerryzh168 jerryzh168 mentioned this pull request Jul 31, 2019
soumith pushed a commit that referenced this pull request Aug 1, 2019
Summary:
accidently calls clone, but what we want is creating an empty tensor and set storage.

Pull Request resolved: #23452
ghstack-source-id: 87438096

Differential Revision: D16442756

fbshipit-source-id: 6d5663f82c9bd4e9de8fc846c52992477843af6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general module: internals Related to internal abstractions in c10 and ATen oncall: quantization Quantization support in PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants