-
Notifications
You must be signed in to change notification settings - Fork 24.4k
[fix] at::view #23452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[fix] at::view #23452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accidently calls clone, but what we want is creating an empty tensor and set storage. Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
Closed
accidently calls clone, but what we want is creating an empty tensor and set storage. Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168
added a commit
that referenced
this pull request
Jul 27, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage. Pull Request resolved: #23452 ghstack-source-id: 87295248 Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
z-a-f
approved these changes
Jul 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
accidently calls clone, but what we want is creating an empty tensor and set storage. Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168
added a commit
that referenced
this pull request
Jul 28, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage. Pull Request resolved: #23452 ghstack-source-id: 87306405 Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
accidently calls clone, but what we want is creating an empty tensor and set storage. Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168
added a commit
that referenced
this pull request
Jul 29, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage. Pull Request resolved: #23452 ghstack-source-id: 87319193 Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
@pytorchbot retest this please |
accidently calls clone, but what we want is creating an empty tensor and set storage. Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168
added a commit
that referenced
this pull request
Jul 29, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage. Pull Request resolved: #23452 ghstack-source-id: 87329201 Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
@pytorchbot retest this please |
@pytorchb retest this please |
gchanan
reviewed
Jul 29, 2019
gchanan
approved these changes
Jul 29, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage. Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
accidently calls clone, but what we want is creating an empty tensor and set storage. Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168
added a commit
that referenced
this pull request
Jul 29, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage. Pull Request resolved: #23452 ghstack-source-id: 87373215 Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
accidently calls clone, but what we want is creating an empty tensor and set storage. Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168
added a commit
that referenced
this pull request
Jul 30, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage. Pull Request resolved: #23452 ghstack-source-id: 87410859 Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
accidently calls clone, but what we want is creating an empty tensor and set storage. Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
jerryzh168
added a commit
that referenced
this pull request
Jul 30, 2019
accidently calls clone, but what we want is creating an empty tensor and set storage. Pull Request resolved: #23452 ghstack-source-id: 87438096 Differential Revision: [D16442756](https://our.internmc.facebook.com/intern/diff/D16442756/)
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 31, 2019
Summary: accidently calls clone, but what we want is creating an empty tensor and set storage. Pull Request resolved: pytorch/pytorch#23452 ghstack-source-id: 87438096 Differential Revision: D16442756 fbshipit-source-id: 6d5663f82c9bd4e9de8fc846c52992477843af6a
This pull request has been merged in 775d7bd. |
jerryzh168
added a commit
to jerryzh168/pytorch
that referenced
this pull request
Jul 31, 2019
Summary: accidently calls clone, but what we want is creating an empty tensor and set storage. Pull Request resolved: pytorch#23452 ghstack-source-id: 87438096 Differential Revision: D16442756 fbshipit-source-id: 6d5663f82c9bd4e9de8fc846c52992477843af6a
Merged
soumith
pushed a commit
that referenced
this pull request
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Merged
module: cpu
CPU specific problem (e.g., perf, algorithm)
module: cuda
Related to torch.cuda, and CUDA support in general
module: internals
Related to internal abstractions in c10 and ATen
oncall: quantization
Quantization support in PyTorch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
accidently calls clone, but what we want is creating an empty tensor and set storage.
Differential Revision: D16442756