Skip to content

[jit] add a test for inline tracing #23543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[jit] add a test for inline tracing #23543

wants to merge 1 commit into from

Conversation

suo
Copy link
Member

@suo suo commented Jul 30, 2019 •
edited
Loading

Stack from ghstack:

As title, this pattern exposed a a bug in some name mangling code so worth
including

Differential Revision: D16570826

@suo
[jit] add a test for inline tracing
8c6f7de 
As title, this pattern exposed a a bug in some name mangling code so worth
including
@pytorchbot pytorchbot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jul 30, 2019
suo added a commit that referenced this pull request Jul 30, 2019
@suo
[jit] add a test for inline tracing
8eb6dd2 
As title, this pattern exposed a a bug in some name mangling code so worth
including

ghstack-source-id: aedcf53
Pull Request resolved: #23543
jamesr66a
jamesr66a approved these changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests

@zou3519 zou3519 deleted the gh/suo/111/head branch July 31, 2019 07:09
@facebook-github-bot
Copy link
Contributor

@suo merged this pull request in 2aaeccd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesr66a jamesr66a jamesr66a approved these changes

Assignees
No one assigned
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suo @facebook-github-bot @jamesr66a @pytorchbot @mruberry