Skip to content

Add logical_not operator. #23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Add logical_not operator. #23839

wants to merge 19 commits into from

Conversation

xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Aug 5, 2019

Stack from ghstack:

Close #23836

Pull Request resolved: #23839

Differential Revision: D16678301

@pytorchbot pytorchbot added module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general module: docs Related to our documentation, both in docs/ and docblocks module: internals Related to internal abstractions in c10 and ATen module: operators labels Aug 5, 2019
@xuhdev xuhdev requested a review from gchanan August 5, 2019 23:27
@xuhdev xuhdev mentioned this pull request Aug 6, 2019
Related to #23836

Pull Request resolved: #23839
xuhdev added a commit that referenced this pull request Aug 6, 2019
xuhdev added a commit that referenced this pull request Aug 6, 2019
@xuhdev xuhdev requested a review from gchanan August 6, 2019 18:20
@gchanan gchanan added this to the 1.2 milestone Aug 6, 2019
xuhdev added a commit that referenced this pull request Aug 6, 2019
xuhdev added a commit that referenced this pull request Aug 6, 2019
@xuhdev xuhdev requested a review from gchanan August 6, 2019 18:58
xuhdev added a commit that referenced this pull request Aug 6, 2019
xuhdev added a commit that referenced this pull request Aug 7, 2019
@gchanan
Copy link
Contributor

gchanan commented Aug 7, 2019

@xuhdev: are all your recent changes to this stack just merges/rebases? I need to know if landing a prior version is safe.

also, can you stop merging/rebasing? I already checked that the failures weren't related to this diff, and we have some internal systems that will reject commits if the version we are trying to merge isn't up-to-date with the the PR. I'm not sure if the merges will go through now or I'll have to do redo it.

I realize we have no automated communication on this state so this is totally invisible to you, sorry about that!

@xuhdev
Copy link
Collaborator Author

xuhdev commented Aug 7, 2019

@gchanan Yes, I just rebased this morning, in case there's any conflict. Sorry for the confusion!

@gchanan
Copy link
Contributor

gchanan commented Aug 7, 2019

ok, I think it makes the most sense to punt on getting this into v1.2 -- mainly because we can't land anything right now.

@gchanan gchanan removed this from the 1.2 milestone Aug 7, 2019
@gchanan
Copy link
Contributor

gchanan commented Aug 7, 2019

Also, no need to apologize -- thanks so much for your contributions, they are really great.

@xuhdev
Copy link
Collaborator Author

xuhdev commented Aug 7, 2019

@gchanan No problem! Thanks for your review!

xuhdev added a commit that referenced this pull request Aug 12, 2019
xuhdev added a commit that referenced this pull request Aug 12, 2019
xuhdev added a commit that referenced this pull request Aug 12, 2019
xuhdev added a commit that referenced this pull request Aug 12, 2019
xuhdev added a commit that referenced this pull request Aug 13, 2019
xuhdev added a commit that referenced this pull request Aug 14, 2019
@zou3519 zou3519 deleted the gh/xuhdev/18/head branch August 15, 2019 15:43
zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 15, 2019
Summary:
Pull Request resolved: pytorch/pytorch#23839

Close #23836

Pull Request resolved: pytorch/pytorch#23839

Test Plan: Imported from OSS

Differential Revision: D16678301

Pulled By: gchanan

fbshipit-source-id: 54e7b3f3b04c577e239b88493247e1c036266774
@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in 1f4c736.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general module: docs Related to our documentation, both in docs/ and docblocks module: internals Related to internal abstractions in c10 and ATen open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants