-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Add logical_not operator. #23839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logical_not operator. #23839
Conversation
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
@xuhdev: are all your recent changes to this stack just merges/rebases? I need to know if landing a prior version is safe. also, can you stop merging/rebasing? I already checked that the failures weren't related to this diff, and we have some internal systems that will reject commits if the version we are trying to merge isn't up-to-date with the the PR. I'm not sure if the merges will go through now or I'll have to do redo it. I realize we have no automated communication on this state so this is totally invisible to you, sorry about that! |
@gchanan Yes, I just rebased this morning, in case there's any conflict. Sorry for the confusion! |
ok, I think it makes the most sense to punt on getting this into v1.2 -- mainly because we can't land anything right now. |
Also, no need to apologize -- thanks so much for your contributions, they are really great. |
@gchanan No problem! Thanks for your review! |
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Close #23836 Pull Request resolved: #23839 Differential Revision: [D16678301](https://our.internmc.facebook.com/intern/diff/D16678301)
Summary: Pull Request resolved: pytorch/pytorch#23839 Close #23836 Pull Request resolved: pytorch/pytorch#23839 Test Plan: Imported from OSS Differential Revision: D16678301 Pulled By: gchanan fbshipit-source-id: 54e7b3f3b04c577e239b88493247e1c036266774
Stack from ghstack:
Close #23836
Pull Request resolved: #23839
Differential Revision: D16678301