[quantization] jit.script() testing and fixes #23891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This adds an initial set of testing coverage for quantization that checks if the modules can be scripted. Testing for tracing and serialization is forthcoming
This was referenced Aug 6, 2019
|
Marking as WIP since i'm adding actual invocation to the tests |
jamesr66a
changed the title
This adds an initial set of testing coverage for quantization that checks if the modules can be scripted. Testing for tracing and serialization is forthcoming
jamesr66a
changed the title
raghuramank100
approved these changes
Aug 7, 2019
z-a-f
approved these changes
Aug 7, 2019
| @@ -33,7 +34,7 @@ def test_relu_api(self): | |||
| self.assertEqual(qY, qY_hat) | |||
|
|
|||
|
|
|||
| class ModuleAPITest(TestCase): | |||
| class ModuleAPITest(QuantizationTestCase): | |||
There was a problem hiding this comment.
We should probably move the scriptability tests into their own test class. Maybe into ScriptabilityTests.
This adds an initial set of testing coverage for quantization that checks if the modules can be scripted. Testing for tracing and serialization is forthcoming Differential Revision: [D16698045](https://our.internmc.facebook.com/intern/diff/D16698045)
|
Updated per @raghuramank100's suggestion. @zafartahirov @raghuramank100 PTAL |
|
@jamesr66a merged this pull request in a35d290. |
|
@jamesr66a merged this pull request in a35d290. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This adds an initial set of testing coverage for quantization that checks if the modules can be scripted. Testing for tracing and serialization is forthcoming
Differential Revision: D16698045