Fix validation of dynamic axes names

[MaximKalininMS]

Existing code adds two enumerators to the set instead of forming their union.

[facebook-github-bot]

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[ezyang]

It would be really nice if there was a test, but this is the second time I saw this exact patch in the PR queue, so let's go and merge it first...

[MaximKalininMS]

@ezyang I added a test. Any idea why it failed in "ci/circleci: caffe2_onnx_py2_gcc5_ubuntu16_04_test"?

[ezyang]

Seems like the new test doesn't work:

Aug 10 00:24:39 =================================== FAILURES ===================================
Aug 10 00:24:39 _____ TestUtilityFuns.test_validate_dynamic_axes_invalid_input_output_name _____
Aug 10 00:24:39 
Aug 10 00:24:39 self = <test_utility_funs.TestUtilityFuns testMethod=test_validate_dynamic_axes_invalid_input_output_name>
Aug 10 00:24:39 
Aug 10 00:24:39     def test_validate_dynamic_axes_invalid_input_output_name(self):
Aug 10 00:24:39         import warnings
Aug 10 00:24:39         with warnings.catch_warnings(record=True) as w:
Aug 10 00:24:39             utils._validate_dynamic_axes({'input1': {}, 'output': {},
Aug 10 00:24:39                                          'invalid_name1': {}, 'invalid_name2': {}},
Aug 10 00:24:39                                           None, ['input1', 'input2'], ['output'])
Aug 10 00:24:39             messages = [str(warning.message) for warning in w]
Aug 10 00:24:39 >       assert "Provided key invalid_name1 for dynamic axes is not a valid input/output name" in messages
Aug 10 00:24:39 E       AssertionError: assert 'Provided key invalid_name1 for dynamic axes is not a valid input/output name' in []

[MaximKalininMS]

@ezyang Yes, I understand that :) However the same test passes in other configurations, e.g. caffe2_onnx_py3_6_clang7_ubuntu16_04_test. Actually these seem to be the only configurations where the test is running, so maybe python2-specific problem? I'll try to figure out.

[ezyang]

We only run the onnx tests in the _onnx_ configuration ;)

[MaximKalininMS]

@ezyang I fixed the test, the remaining CI issues seem unrelated to my change.

[facebook-github-bot]

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@ezyang merged this pull request in 517b3c4.