reduce memory usage for centered rmsprop #24170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentqb
approved these changes
Aug 13, 2019
| @@ -88,7 +88,7 @@ def step(self, closure=None): | |||
| if group['centered']: | |||
| grad_avg = state['grad_avg'] | |||
| grad_avg.mul_(alpha).add_(1 - alpha, grad) | |||
| avg = square_avg.addcmul(-1, grad_avg, grad_avg).sqrt().add_(group['eps']) | |||
| avg = square_avg.addcmul(-1, grad_avg, grad_avg).sqrt_().add_(group['eps']) | |||
| else: | |||
| avg = square_avg.sqrt().add_(group['eps']) | |||
There was a problem hiding this comment.
We can use sqrt_ here too, is that correct?
There was a problem hiding this comment.
No. Since square_avg is a state that we maintain, we should not modify it here.
There was a problem hiding this comment.
@vincentqb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@vincentqb merged this pull request in bd054e7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce gpu memory usage by using in-place operation