Merge ProfiledTensorType and TensorType #24284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR finishes the unification of all Tensor types into a single object. ProfiledTensorType is renamed to TensorType and the old TensorType is deleted. Notes: * Fixes bug in merge for VaryingShape by changing its representation to an optional list of optional ints. * Removes ProfiledTensorType::create(type) invocations that can now simply be expect calls on tensor type.
pytorchbot
added
oncall: jit
Merge ProfiledTensorType and TensorType This PR finishes the unification of all Tensor types into a single object. ProfiledTensorType is renamed to TensorType and the old TensorType is deleted. Notes: * Fixes bug in merge for VaryingShape by changing its representation to an optional list of optional ints. * Removes ProfiledTensorType::create(type) invocations that can now simply be expect calls on tensor type. gh-metadata: pytorch pytorch 24284 gh/zdevito/85/head
Merge ProfiledTensorType and TensorType This PR finishes the unification of all Tensor types into a single object. ProfiledTensorType is renamed to TensorType and the old TensorType is deleted. Notes: * Fixes bug in merge for VaryingShape by changing its representation to an optional list of optional ints. * Removes ProfiledTensorType::create(type) invocations that can now simply be expect calls on tensor type. gh-metadata: pytorch pytorch 24284 gh/zdevito/85/head
Merge ProfiledTensorType and TensorType This PR finishes the unification of all Tensor types into a single object. ProfiledTensorType is renamed to TensorType and the old TensorType is deleted. Notes: * Fixes bug in merge for VaryingShape by changing its representation to an optional list of optional ints. * Removes ProfiledTensorType::create(type) invocations that can now simply be expect calls on tensor type. gh-metadata: pytorch pytorch 24284 gh/zdevito/85/head
Merge ProfiledTensorType and TensorType This PR finishes the unification of all Tensor types into a single object. ProfiledTensorType is renamed to TensorType and the old TensorType is deleted. Notes: * Fixes bug in merge for VaryingShape by changing its representation to an optional list of optional ints. * Removes ProfiledTensorType::create(type) invocations that can now simply be expect calls on tensor type. gh-metadata: pytorch pytorch 24284 gh/zdevito/85/head
Merge ProfiledTensorType and TensorType This PR finishes the unification of all Tensor types into a single object. ProfiledTensorType is renamed to TensorType and the old TensorType is deleted. Notes: * Fixes bug in merge for VaryingShape by changing its representation to an optional list of optional ints. * Removes ProfiledTensorType::create(type) invocations that can now simply be expect calls on tensor type. gh-metadata: pytorch pytorch 24284 gh/zdevito/85/head
Krovatkin
approved these changes
Aug 16, 2019
| "aten::prod(Tensor self, *, int? dtype) -> Tensor", | ||
| }, | ||
| [](Node* node) -> type_vec_t { | ||
| if (auto type = node->input(0)->type()->cast<TensorType>()) { |
There was a problem hiding this comment.
aren't we guaranteed that self has a tensor type here?
There was a problem hiding this comment.
yes, seems like that is true
aten/src/ATen/core/jit_type.h
Outdated
| VaryingShape(const std::vector<int64_t>& vec) | ||
| : size_(vec.size()), dims_(vec.begin(), vec.end()) {} | ||
| : VaryingShape(ListOfOptionalInts(vec.begin(), vec.end())) {} |
There was a problem hiding this comment.
Errr, deja vu, isn't there another PR floating with this exact change?
There was a problem hiding this comment.
yeah, I split that out from this one, because it is higher priority to merge that one to prevent a hang in some client code. I will delete these changes from this PR.
Merge ProfiledTensorType and TensorType This PR finishes the unification of all Tensor types into a single object. ProfiledTensorType is renamed to TensorType and the old TensorType is deleted. Notes: * Fixes bug in merge for VaryingShape by changing its representation to an optional list of optional ints. * Removes ProfiledTensorType::create(type) invocations that can now simply be expect calls on tensor type. gh-metadata: pytorch pytorch 24284 gh/zdevito/85/head
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2019
Summary: Pull Request resolved: #24284 This PR finishes the unification of all Tensor types into a single object. ProfiledTensorType is renamed to TensorType and the old TensorType is deleted. Notes: * Fixes bug in merge for VaryingShape by changing its representation to an optional list of optional ints. * Removes ProfiledTensorType::create(type) invocations that can now simply be expect calls on tensor type. Test Plan: Imported from OSS Differential Revision: D16794034 Pulled By: zdevito fbshipit-source-id: 10362398d0bb166d0d385d74801e95d9b87d9dfc
zdevito
added a commit
to zdevito/ATen
that referenced
this pull request
Aug 20, 2019
Summary: Pull Request resolved: pytorch/pytorch#24284 This PR finishes the unification of all Tensor types into a single object. ProfiledTensorType is renamed to TensorType and the old TensorType is deleted. Notes: * Fixes bug in merge for VaryingShape by changing its representation to an optional list of optional ints. * Removes ProfiledTensorType::create(type) invocations that can now simply be expect calls on tensor type. Test Plan: Imported from OSS Differential Revision: D16794034 Pulled By: zdevito fbshipit-source-id: 10362398d0bb166d0d385d74801e95d9b87d9dfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR finishes the unification of all Tensor types into a single object.
ProfiledTensorType is renamed to TensorType and the old TensorType is
deleted.
Notes:
optional list of optional ints.
simply be expect calls on tensor type.
Differential Revision: D16794034