[pt1] Use the EmbeddingLookupIdx API which takes the offsets instead of lengths #24945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of lengths As Title says. Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
jianyuh
added a commit
that referenced
this pull request
Aug 21, 2019
…of lengths As Title says. Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/) ghstack-source-id: 88688199 Pull Request resolved: #24945
…ts instead of lengths" As Title says. Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
jianyuh
added a commit
that referenced
this pull request
Aug 21, 2019
…lengths Pull Request resolved: #24945 As Title says. ghstack-source-id: 88699061 Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
…ts instead of lengths" As Title says. Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
jianyuh
added a commit
that referenced
this pull request
Aug 22, 2019
…lengths Pull Request resolved: #24945 As Title says. ghstack-source-id: 88778883 Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
…ts instead of lengths" As Title says. Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
…ts instead of lengths" As Title says. Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
…ts instead of lengths" As Title says. Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
jianyuh
added a commit
that referenced
this pull request
Aug 23, 2019
…lengths Pull Request resolved: #24945 As Title says. ghstack-source-id: 88884366 Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
…ts instead of lengths" As Title says. Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
jianyuh
added a commit
that referenced
this pull request
Aug 23, 2019
…lengths Pull Request resolved: #24945 As Title says. ghstack-source-id: 88903516 Differential Revision: [D16930519](https://our.internmc.facebook.com/intern/diff/D16930519/)
|
This pull request has been merged in 363655d. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 24, 2019
…s (#24945) Summary: Pull Request resolved: pytorch/pytorch#24945 As Title says. ghstack-source-id: 88903516 Test Plan: To Check with CI. ``` import torch, time eb = torch.nn.EmbeddingBag(1000000, 64, mode='sum') input = torch.LongTensor(1500).random_(0, 1000000) offsets = torch.zeros(64, dtype=torch.int64) niter = 10000 s = time.time() for i in range(niter): out = eb(input, offsets) time_per_iter = (time.time() - s) / niter print('time_per_iter', time_per_iter) print('GB/s', (input.numel() * 64 * 4 + out.numel() * 4) / time_per_iter / 1e9) ``` Reviewed By: bddppq Differential Revision: D16930519 fbshipit-source-id: 44d59ca2588deecde1adb096673fc100bcd9bc46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
As Title says.
Differential Revision: D16930519