Skip to content

[jit] Add source location to class instantiation error #24990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[jit] Add source location to class instantiation error #24990

wants to merge 5 commits into from

Conversation

driazati
Copy link
Contributor

@driazati driazati commented Aug 21, 2019 •
edited
Loading

Fixes #24987

Differential Revision: D17099779

@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: pybind Related to our Python bindings / interactions with other Python libraries labels Aug 21, 2019
@driazati driazati requested a review from eellison August 23, 2019 00:13
eellison
eellison approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be nice if the error had the same stacktrace as with a JIT compilation error

@driazati
Copy link
Contributor Author

Looks good. It would be nice if the error had the same stacktrace as with a JIT compilation error

FrontendError adds that automatically

@driazati driazati requested a review from apaszke as a code owner August 28, 2019 20:12
@facebook-github-bot
Copy link
Contributor

@driazati merged this pull request in 43c4b9f.

@suo
Copy link
Member

suo commented Aug 29, 2019

This PR broke pytorch_linux_xenial_cuda9_cudnn7_py3_slow_test. I am reverting

@suo
Copy link
Member

suo commented Aug 29, 2019

The PR doesn't revert cleanly (I assume because of the fix for the lint breakage also caused by this PR). @driazati can you issue a fix asap?

@driazati
Copy link
Contributor Author

Fix in #25378

@facebook-github-bot facebook-github-bot deleted the driazati/front/1 branch July 13, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees
No one assigned
Labels
Merged module: pybind Related to our Python bindings / interactions with other Python libraries oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JIT] "cannot instantiate class object" error does not print out stacktrace
6 participants
@driazati @facebook-github-bot @suo @eellison @pytorchbot @mruberry