cleanup tmp name generation #25065
Closed
cleanup tmp name generation #25065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using global atomic variables is bad because sending the same AST through the compiler twice will produce different graphs. This makes it a member of the translation struct.
eellison
approved these changes
Aug 23, 2019
torch/csrc/jit/script/compiler.cpp
Outdated
| @@ -522,6 +522,10 @@ struct to_ir { | |||
| // `next` that points to the most immediate enclosing scope's value. | |||
| std::shared_ptr<Environment> environment_stack; | |||
| std::vector<DefContext> def_stack_; | |||
| size_t temp_name_count_ = 0; | |||
| std::string createTempName(const std::string& prefix) { | |||
| return prefix + std::to_string(temp_name_count_); | |||
torch/csrc/jit/script/compiler.cpp
Outdated
| static std::atomic<size_t> tmp_count{0}; | ||
| const auto tmp_name = | ||
| std::string("___list_acc") + std::to_string(tmp_count++); | ||
| const auto tmp_name = createTempName("___list_acc"); |
There was a problem hiding this comment.
unrelated to your diff but it's better practice to prefix the names with $ so that there is no possibility of user collision
cleanup tmp name generation Using global atomic variables is bad because sending the same AST through the compiler twice will produce different graphs. This makes it a member of the translation struct. gh-metadata: pytorch pytorch 25065 gh/zdevito/93/head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Using global atomic variables is bad because sending the same AST through
the compiler twice will produce different graphs. This makes it a
member of the translation struct.
Differential Revision: D16975355