-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Move BUILD_NAMEDTENSOR macro out of header areas #25256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci]
This was referenced Aug 27, 2019
Move BUILD_NAMEDTENSOR macro out of header areas Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head
Move BUILD_NAMEDTENSOR macro out of header areas Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head
Move BUILD_NAMEDTENSOR macro out of header areas Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head
Move BUILD_NAMEDTENSOR macro out of header areas Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head
Move BUILD_NAMEDTENSOR macro out of header areas Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head
Move BUILD_NAMEDTENSOR macro out of header areas Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head
Move BUILD_NAMEDTENSOR macro out of header areas Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head
Closed
Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head Differential Revision: [D17076893](https://our.internmc.facebook.com/intern/diff/D17076893)
zou3519
added a commit
that referenced
this pull request
Aug 30, 2019
Pull Request resolved: #25256 Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag. Here is the approach: - Move the macro out of header areas - Include a new `enable_namedtensor.h` header that does a `#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR`. - Include `enable_namedtensor.h` where necessary. This only really needs to happen in two files (c10/TensorImpl.h, ATen/Dimname.h). - Incrementally delete usages of the BUILD_NAMEDTENSOR macro later. The alternative is to straight up delete all instances of BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge conflicts, and isn't incremental. Along with the above, some work needs to be done on feature flagging named tensors, and merging the namedtensor CI with the regular CI, and communicating with devs. This work will too be done incrementally. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head Differential Revision: [D17076893](https://our.internmc.facebook.com/intern/diff/D17076893/) ghstack-source-id: 89222500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: cuda
Related to torch.cuda, and CUDA support in general
module: internals
Related to internal abstractions in c10 and ATen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Context: I am starting to work on removing the BUILD_NAMEDTENSOR flag.
Here is the approach:
enable_namedtensor.h
header that does a#ifndef BUILD_NAMEDTENSOR #define BUILD_NAMEDTENSOR
.enable_namedtensor.h
where necessary. This only really needsto happen in two files (c10/TensorImpl.h, ATen/Dimname.h).
The alternative is to straight up delete all instances of
BUILD_NAMEDTENSOR. This alternative could be disruptive, lead to merge
conflicts, and isn't incremental.
Along with the above, some work needs to be done on feature flagging
named tensors, and merging the namedtensor CI with the regular CI, and
communicating with devs. This work will too be done incrementally.
Test Plan
gh-metadata: pytorch pytorch 25256 gh/zou3519/121/head
Differential Revision: D17076893