remove protobuf usage from mobile build #25493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linbinyu
force-pushed
the
export-D17116846
branch
from
0e9cb01 to
c5c2a31
Compare
linbinyu
force-pushed
the
export-D17116846
branch
from
c5c2a31 to
44adef3
Compare
Summary: Pull Request resolved: pytorch#25493 remove protobuf usage from mobile build Test Plan: buck build //caffe2:torch buck build -c 'protobuf.use_v3=true' -c 'project.ignore=true' fbsource//fbandroid/mode/dev_clang_asan //xplat/experimental/pytorch/predictor:predictor Reviewed By: ljk53 Differential Revision: D17116846 fbshipit-source-id: f46ddd9e07942d605deef38d9bc8323346b48dd8
linbinyu
force-pushed
the
export-D17116846
branch
from
44adef3 to
acf1813
Compare
|
This pull request has been merged in 885da48. |
ljk53
added a commit
that referenced
this pull request
Sep 4, 2019
Summary: Continue the work of PR #25493. Remove dependencies of generated protobuf headers from jit/import.cpp. Test Plan: - builds; - with stacked PR to remove protobuf from cmake;
ljk53
added a commit
that referenced
this pull request
Sep 5, 2019
…port.cpp" Summary: Continue the work of PR #25493. Remove dependencies of generated protobuf headers from jit/import.cpp. Test Plan: - builds; - with stacked PR to remove protobuf from cmake; Differential Revision: [D17183549](https://our.internmc.facebook.com/intern/diff/D17183549)
ljk53
added a commit
that referenced
this pull request
Sep 5, 2019
…port.cpp" Summary: Continue the work of PR #25493. Remove dependencies of generated protobuf headers from jit/import.cpp. Test Plan: - builds; - with stacked PR to remove protobuf from cmake; Differential Revision: [D17183549](https://our.internmc.facebook.com/intern/diff/D17183549)
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 5, 2019
Summary: Pull Request resolved: #25649 Continue the work of PR #25493 to remove dependencies of generated protobuf headers from jit/import.cpp. Instead of adding intrusive #if/#else to gate the legacy functions, moving them into a separate file. Keep the ScriptModuleDeserializer structure as otherwise it will require a lot of interface changes. There is not much state to copy from ScriptModuleDeserializer as it only extracts extra_files before calling into LEGACY_deserialize. There is no state to copy back into ScriptModuleDeserializer either as it directly returns script::Module. Test Plan: - builds; - with stacked PR to remove protobuf from cmake; - load and run ResNet-18 in model.json format with non-mobile build; - load and run ResNet-18 in pickle format with mobile build; Differential Revision: D17183549 Pulled By: ljk53 fbshipit-source-id: 2947b95659cd16046d9595fb118d22acc179b3ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: remove protobuf usage from mobile build
Test Plan: buck build //caffe2:torch
Differential Revision: D17116846