Use whitelist instead of blacklist for USE_DISTRIBUTED #25759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #25260, USE_DISTRIBUTED was defaulted to OFF for Windows and macOS only. The Android builds didn't run for the PR and started to fail when it was merged to master. It turns out the mobile builds explicitly disable USE_DISTRIBUTED but only after the USE_DISTRIBUTED option, and derivative dependent options were defined. The result being that USE_GLOO was enabled while USE_DISTRIBUTED was disabled. This commit ensures that USE_DISTRIBUTED defaults to OFF unless the build is for a supported platform. Differential Revision: [D17224842](https://our.internmc.facebook.com/intern/diff/D17224842/)
pietern
added a commit
that referenced
this pull request
Sep 6, 2019
In #25260, USE_DISTRIBUTED was defaulted to OFF for Windows and macOS only. The Android builds didn't run for the PR and started to fail when it was merged to master. It turns out the mobile builds explicitly disable USE_DISTRIBUTED but only after the USE_DISTRIBUTED option, and derivative dependent options were defined. The result being that USE_GLOO was enabled while USE_DISTRIBUTED was disabled. This commit ensures that USE_DISTRIBUTED defaults to OFF unless the build is for a supported platform. Differential Revision: [D17224842](https://our.internmc.facebook.com/intern/diff/D17224842/) ghstack-source-id: 89613698 Pull Request resolved: #25759
soumith
approved these changes
Sep 6, 2019
|
This pull request has been merged in 3e84311. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In #25260, USE_DISTRIBUTED was defaulted to OFF for Windows and macOS
only. The Android builds didn't run for the PR and started to fail
when it was merged to master. It turns out the mobile builds
explicitly disable USE_DISTRIBUTED but only after the USE_DISTRIBUTED
option, and derivative dependent options were defined. The result
being that USE_GLOO was enabled while USE_DISTRIBUTED was disabled.
This commit ensures that USE_DISTRIBUTED defaults to OFF unless the
build is for a supported platform.
Differential Revision: D17224842