Skip to content

fix typo: toDense --> to_dense #25706 #25832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix typo: toDense --> to_dense #25706 #25832

wants to merge 1 commit into from

Conversation

Nikronic
Copy link
Contributor

@Nikronic Nikronic commented Sep 8, 2019

Only fixes a minor typo in torch.sparse.FloatTensor docs.

@pytorchbot pytorchbot added the module: docs Related to our documentation, both in docs/ and docblocks label Sep 8, 2019
@Nikronic Nikronic changed the title fix typo: toDense --> to_dense #25706 [WIP] fix typo: toDense --> to_dense #25706 Sep 8, 2019
@Nikronic
Copy link
Contributor Author

Nikronic commented Sep 8, 2019

Sorry, but I cannot find any useful information in the description provided to track the failed check.

@Nikronic Nikronic changed the title [WIP] fix typo: toDense --> to_dense #25706 fix typo: toDense --> to_dense #25706 Sep 8, 2019
@Nikronic
Copy link
Contributor Author

Nikronic commented Sep 9, 2019

@ezyang Sorry if I ask, but I got some failed test which I really cannot figure out what is happening. I have read the related docs as far as I know, but I am confused how changing a typo can cause those fails. Thanks you

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@soumith
Copy link
Member

soumith commented Sep 10, 2019

it's a broken test i think, ignore.

@facebook-github-bot
Copy link
Contributor

@soumith merged this pull request in 1777eb2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: docs Related to our documentation, both in docs/ and docblocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants