Remove tools/setup_helpers/dist_check.py #25879
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What dist_check.py does is largely merely determining whether we should use set "USE_IBVERBS" to ON or OFF when the user sets "USE_GLOO_IBVERBS" to ON. But this is unnecessary, because this complicated determination will always be overrided by gloo: https://github.com/facebookincubator/gloo/blob/2101e02ceabd9f1b0bb354f6ea705cefe83558b2/cmake/Dependencies.cmake#L19-L28 Since dist_check.py becomes irrelevant, this commit also simplifies the setting of `USE_DISTRIBUTION`, and deprecate `USE_GLOO_IBVERBS` in favor of `USE_IBVERBS`.
|
This is great, thank you! |
There was a problem hiding this comment.
@pietern is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What dist_check.py does is largely merely determining whether we should
use set "USE_IBVERBS" to ON or OFF when the user sets "USE_GLOO_IBVERBS"
to ON. But this is unnecessary, because this complicated determination
will always be overrided by gloo:
https://github.com/facebookincubator/gloo/blob/2101e02ceabd9f1b0bb354f6ea705cefe83558b2/cmake/Dependencies.cmake#L19-L28
Since dist_check.py becomes irrelevant, this commit also simplifies the
setting of
USE_DISTRIBUTED(by removing its explicit setting in Python scripts), and deprecateUSE_GLOO_IBVERBSin favorof
USE_IBVERBS.