Clarify and correct the doc of atan2. #26180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
the
module: docs
|
@pytorchbot rebase this please |
|
do you know why these tests are failing? |
gchanan
reviewed
Sep 17, 2019
xuhdev
force-pushed
the
atan2-doc
branch
2 times, most recently
from
88b236f to
29334f8
Compare
|
@gchanan The reason the test failed before was |
albanD
requested changes
Sep 17, 2019
torch/_torch_docs.py
Outdated
| Returns a new tensor with the arctangent of the elements of :attr:`input` | ||
| and :attr:`other`. | ||
| Returns a new tensor with the arctangent of the angle between | ||
| :math:`(\text{{other}}_{{i}}, \text{{input}}_{{i}})` and :math:`(1, 0)`. |
There was a problem hiding this comment.
If you talk about vectors here, it should be be (input[i], other[i]) no?
Or you can define it as tan^{-1} ( other[i] / input[i]).
There was a problem hiding this comment.
Actually maybe something inspired from what the numpy doc says would be clearer?
There was a problem hiding this comment.
I rewrote this paragraph. Please see the new update
albanD
reviewed
Sep 19, 2019
There was a problem hiding this comment.
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mingbowan
pushed a commit
to mingbowan/pytorch
that referenced
this pull request
Sep 23, 2019
Summary: Pull Request resolved: pytorch#26180 Reviewed By: ezyang Differential Revision: D17500224 Pulled By: albanD fbshipit-source-id: 98b9f32aa443963fe1e89b83e15bed9ff83a2694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.