-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Enable creation of boxing wrappers for some aten operators #26273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/)
[namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) ghstack-source-id: 90146417 Pull Request resolved: #26273
For the record: I oppose adding a second partial state here. We should have 100% coverage for boxing wrappers in c10 if we add it. If you can't handle an op, disable it from c10 instead. |
The reason for the two-step process is that it allows us to delete My original plan was what you're describing - keep the c10 dispatcher pure and only move what can be moved, add features and operators step-by-step. But you and @dzhulgakov convinced me that having multiple dispatchers is a major issue for other development flows (like multi dispatch or lazy) and that it's important to get down to only one dispatcher earlier than that and that it's ok if the c10 dispatcher has both unboxed_only and regular ops for a while. |
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
Pull Request resolved: #26273 [namedtensor ci] ghstack-source-id: 90222273 Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/)
OK |
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
Pull Request resolved: #26273 [namedtensor ci] ghstack-source-id: 90310841 Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/)
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
Pull Request resolved: #26273 [namedtensor ci] ghstack-source-id: 90315164 Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/)
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
Pull Request resolved: #26273 [namedtensor ci] ghstack-source-id: 90315398 Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/)
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
…rators" [namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
[namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
[namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
[namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
[namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
[namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
[namedtensor ci] Differential Revision: [D17393318](https://our.internmc.facebook.com/intern/diff/D17393318/) [ghstack-poisoned]
Summary: Pull Request resolved: pytorch/pytorch#26273 [namedtensor ci] ghstack-source-id: 90459908 Test Plan: unit tests Differential Revision: D17393318 fbshipit-source-id: 1831da121ca7c64d1148b34c88a57bdc16c9fddf
This pull request has been merged in 5016796. |
…6273) Summary: Pull Request resolved: pytorch#26273 [namedtensor ci] ghstack-source-id: 90459908 Test Plan: unit tests Differential Revision: D17393318 fbshipit-source-id: 1831da121ca7c64d1148b34c88a57bdc16c9fddf
Stack from ghstack:
[namedtensor ci]
Differential Revision: D17393318