Skip to content

Refactor Dimname.h API to be nicer #26366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Refactor Dimname.h API to be nicer #26366

wants to merge 5 commits into from

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Sep 17, 2019 •
edited
Loading

Stack from ghstack:

Changes:

  • NameType::NORMAL -> NameType::BASIC
  • Dimname::is_wildcard -> Dimname::isWildcard()
  • Dimname::is_normal -> Dimname::isBasic().
  • at::is_valid_identifier -> Dimname::isValidName(string)
  • at::match, at::unify are now methods on Dimname.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan:

  • [namedtensor ci]

Differential Revision: D17484757

@zou3519
Refactor Dimname.h API to be nicer
806142b 
Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan:
- [namedtensor ci]
@pytorchbot pytorchbot added module: internals Related to internal abstractions in c10 and ATen module: operators labels Sep 17, 2019
This was referenced Sep 17, 2019
Closed
Closed
@zou3519
Update on "Refactor Dimname.h API to be nicer"
1a63354 
Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan:
- [namedtensor ci]
zou3519 added a commit that referenced this pull request Sep 17, 2019
@zou3519
Refactor Dimname.h API to be nicer
5052609 
Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan:
- [namedtensor ci]

ghstack-source-id: dd76957
Pull Request resolved: #26366
@zou3519 zou3519 requested a review from nairbv September 17, 2019 20:22
@zou3519
Update on "Refactor Dimname.h API to be nicer"
e37c69c 
Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan:
- [namedtensor ci]
@zou3519
Update on "Refactor Dimname.h API to be nicer"
239ccc7 
Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan:
- [namedtensor ci]
zou3519 added a commit that referenced this pull request Sep 19, 2019
@zou3519
Refactor Dimname.h API to be nicer
41e6bca 
Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan:
- [namedtensor ci]

ghstack-source-id: db151ce
Pull Request resolved: #26366
@zou3519
Update on "Refactor Dimname.h API to be nicer"
30dcaca 
Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan:
- [namedtensor ci]
@zou3519 zou3519 mentioned this pull request Sep 19, 2019
Closed
zou3519 added a commit that referenced this pull request Sep 19, 2019
@zou3519
Refactor Dimname.h API to be nicer
7c9696a 
Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan:
- [namedtensor ci]

ghstack-source-id: db151ce
Pull Request resolved: #26366
zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 20, 2019
@zou3519 @facebook-github-bot
Refactor Dimname.h API to be nicer (#26366)
0bdba44 
Summary:
Pull Request resolved: pytorch/pytorch#26366

Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan: - [namedtensor ci]

Differential Revision: D17484757

Pulled By: zou3519

fbshipit-source-id: 21c128e5025e81513e14d34506a7d7744caefdc2
@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in 30fc011.

mingbowan pushed a commit to mingbowan/pytorch that referenced this pull request Sep 23, 2019
@zou3519
Refactor Dimname.h API to be nicer (pytorch#26366)
5c11831 
Summary:
Pull Request resolved: pytorch#26366

Changes:
- `NameType::NORMAL` -> `NameType::BASIC`
- `Dimname::is_wildcard` -> `Dimname::isWildcard()`
- `Dimname::is_normal` -> `Dimname::isBasic()`.
- `at::is_valid_identifier` -> `Dimname::isValidName(string)`
- `at::match`, `at::unify` are now methods on `Dimname`.

I am adopting CamelCase for struct members of a named tensor related
struct.

Test Plan: - [namedtensor ci]

Differential Revision: D17484757

Pulled By: zou3519

fbshipit-source-id: 21c128e5025e81513e14d34506a7d7744caefdc2
@facebook-github-bot facebook-github-bot deleted the gh/zou3519/177/head branch October 28, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nairbv nairbv nairbv approved these changes

Assignees
No one assigned
Labels
Merged module: internals Related to internal abstractions in c10 and ATen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zou3519 @facebook-github-bot @nairbv @pytorchbot @mruberry