Skip to content

[C++ API] Distance module #26424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[C++ API] Distance module #26424

wants to merge 11 commits into from

Conversation

jon-tow
Copy link
Contributor

@jon-tow jon-tow commented Sep 18, 2019 •
edited
Loading

Adds Distance module parity.
#25883

@pytorchbot pytorchbot added caffe2 module: build Build system issues module: cpp Related to C++ API labels Sep 18, 2019
@jon-tow jon-tow changed the title [C++ API] Distance module [WIP - C++ API] Distance module Sep 18, 2019
@jon-tow jon-tow changed the title [WIP - C++ API] Distance module [ C++ API] Distance module Sep 18, 2019
@jon-tow jon-tow changed the title [ C++ API] Distance module [C++ API] Distance module Sep 18, 2019
yf225
yf225 reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jon-tow Thanks a lot for the PR and really appreciated it. I left some minor comments on the implementation.

@jon-tow jon-tow requested a review from yf225 September 19, 2019 20:59
@yf225
Copy link
Contributor

yf225 commented Sep 19, 2019

@pytorchbot rebase this please

@yf225 yf225 mentioned this pull request Sep 19, 2019
Open
yf225
yf225 approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jon-tow Thanks so much for the contribution and really appreciated the high-quality work. I will merge it today.

facebook-github-bot
facebook-github-bot reviewed Sep 19, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jon-tow
Copy link
Contributor Author

jon-tow commented Sep 19, 2019

Glad to help out @yf225! Thank you for guiding me through it :).

@yf225
Copy link
Contributor

yf225 commented Sep 20, 2019

@pytorchbot rebase this please

facebook-github-bot
facebook-github-bot reviewed Sep 20, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@yf225 merged this pull request in 872ca91.

@jon-tow jon-tow deleted the cpp-api/distance branch September 20, 2019 16:32
@yf225 yf225 mentioned this pull request Sep 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@yf225 yf225 yf225 approved these changes

@ebetica ebetica Awaiting requested review from ebetica

@goldsborough goldsborough Awaiting requested review from goldsborough

Assignees
No one assigned
Labels
caffe2 Merged module: build Build system issues module: cpp Related to C++ API open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jon-tow @yf225 @facebook-github-bot @ezyang @pytorchbot @mruberry