Don't unconditionally compile runJITCPPTests #31236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not compiled on Windows Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
This was referenced Dec 13, 2019
facebook-github-bot
added
the
oncall: jit
It is not compiled on Windows Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
💊 CircleCI build failures summary and remediationsAs of commit 2671cf1: Commit 2671cf1 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 8 times. |
It is not compiled on Windows Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
eellison
approved these changes
Jan 2, 2020
There was a problem hiding this comment.
LGTM, maybe add note https://github.com/pytorch/pytorch/blob/master/caffe2/CMakeLists.txt#L760 to cross-reference torch/CMakeLists.txt
It is not compiled on Windows Signed-off-by: Edward Z. Yang <[email protected]> Differential Revision: [D19262581](https://our.internmc.facebook.com/intern/diff/D19262581) [ghstack-poisoned]
It is not compiled on Windows Signed-off-by: Edward Z. Yang <[email protected]> Differential Revision: [D19262581](https://our.internmc.facebook.com/intern/diff/D19262581) [ghstack-poisoned]
It is not compiled on Windows Signed-off-by: Edward Z. Yang <[email protected]> Differential Revision: [D19262581](https://our.internmc.facebook.com/intern/diff/D19262581) [ghstack-poisoned]
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
It is not compiled on Windows Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 10cff2f Pull Request resolved: pytorch/pytorch#31236
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#31236 It is not compiled on Windows Signed-off-by: Edward Z. Yang <[email protected]> Test Plan: Imported from OSS Differential Revision: D19262581 Pulled By: ezyang fbshipit-source-id: 80bfa553333a946f00291aaca6ad26313caaa9e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It is not compiled on Windows
Signed-off-by: Edward Z. Yang [email protected]
Differential Revision: D19262581