[DatePipe] add deprecation warnings for DataPipes that will solely exist in TorchData #65827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist in TorchData [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e7b9283 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…l solely exist in TorchData" [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…l solely exist in TorchData" Differential Revision: [D31272794](https://our.internmc.facebook.com/intern/diff/D31272794) cc @VitalyFedyunin ejguan @NivekT [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…l solely exist in TorchData" Differential Revision: [D31272794](https://our.internmc.facebook.com/intern/diff/D31272794) cc @VitalyFedyunin ejguan @NivekT [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Same as the another PR. Could we add this PR to release 1.10? |
This was referenced Sep 30, 2021
malfet
pushed a commit
that referenced
this pull request
Oct 6, 2021
…5932) * Unify the output pathname of archive reader and extractor (#65424) Summary: Pull Request resolved: #65424 This PR is re-implementation for https://github.com/facebookexternal/torchdata/pull/93 Same PR has landed into torchdata https://github.com/facebookexternal/torchdata/pull/157 Test Plan: Imported from OSS Reviewed By: soulitzer Differential Revision: D31090447 Pulled By: ejguan fbshipit-source-id: 45af1ad9b24310bebfd6e010f41cff398946ba65 * [DatePipe] add deprecation warnings for DataPipes that will solely exist in TorchData (#65827) Summary: Pull Request resolved: #65827 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D31272794 Pulled By: NivekT fbshipit-source-id: 8da8266184b4df050422904cbc5fca6d7c3d2e02 * [DataPipe] Fixes an issue where TarArchiveReader closes stream when read into a buffer (#65877) Summary: Pull Request resolved: #65877 Fixes #65808 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D31296041 Pulled By: NivekT fbshipit-source-id: cdcad3a333ae9781d6063678a122a128955b0ff4 Co-authored-by: Erjia Guan <[email protected]>
NivekT
added a commit
that referenced
this pull request
Jan 11, 2022
We labeled these DataPipes as deprecated on Sep 30th, 2021 (#65827). Users should import these DataPipes from [TorchData](https://github.com/pytorch/data) to continue using them. We will be checking for any downstream library usage before landing this PR. All deprecation related to DataPipes are tracked in pytorch/data#163 DataPipes impacted by this PR: | Name | Functional API | Deprecation Date | What Happens Now | ------------- | ------------- | ------------- | ------------- | | BucketBatcher | NA | Sep 30th, 2021 | Remove (moved to TorchData) | HTTPReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | LineReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | TarArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | ZipArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) Lastly, tests related to those DataPipes will also be removed or migrated to TorchData (if they do not already exist there). Differential Revision: [D33532272](https://our.internmc.facebook.com/intern/diff/D33532272) cc ezyang gchanan @VitalyFedyunin ejguan @NivekT [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Jan 11, 2022
We labeled these DataPipes as deprecated on Sep 30th, 2021 (#65827). Users should import these DataPipes from [TorchData](https://github.com/pytorch/data) to continue using them. We will be checking for any downstream library usage before landing this PR. All deprecation related to DataPipes are tracked in pytorch/data#163 DataPipes impacted by this PR: | Name | Functional API | Deprecation Date | What Happens Now | ------------- | ------------- | ------------- | ------------- | | BucketBatcher | NA | Sep 30th, 2021 | Remove (moved to TorchData) | HTTPReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | LineReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | TarArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | ZipArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) Lastly, tests related to those DataPipes will also be removed or migrated to TorchData (if they do not already exist there). Differential Revision: [D33532272](https://our.internmc.facebook.com/intern/diff/D33532272) cc ezyang gchanan @VitalyFedyunin ejguan @NivekT [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Jan 11, 2022
We labeled these DataPipes as deprecated on Sep 30th, 2021 (#65827). Users should import these DataPipes from [TorchData](https://github.com/pytorch/data) to continue using them. We will be checking for any downstream library usage before landing this PR. All deprecation related to DataPipes are tracked in pytorch/data#163 DataPipes impacted by this PR: | Name | Functional API | Deprecation Date | What Happens Now | ------------- | ------------- | ------------- | ------------- | | BucketBatcher | NA | Sep 30th, 2021 | Remove (moved to TorchData) | HTTPReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | LineReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | TarArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | ZipArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) Lastly, tests related to those DataPipes will also be removed or migrated to TorchData (if they do not already exist there). Differential Revision: [D33532272](https://our.internmc.facebook.com/intern/diff/D33532272) cc ezyang gchanan @VitalyFedyunin ejguan @NivekT [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Jan 12, 2022
We labeled these DataPipes as deprecated on Sep 30th, 2021 (#65827). Users should import these DataPipes from [TorchData](https://github.com/pytorch/data) to continue using them. We will be checking for any downstream library usage before landing this PR. All deprecation related to DataPipes are tracked in pytorch/data#163 DataPipes impacted by this PR: | Name | Functional API | Deprecation Date | What Happens Now | ------------- | ------------- | ------------- | ------------- | | BucketBatcher | NA | Sep 30th, 2021 | Remove (moved to TorchData) | HTTPReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | LineReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | TarArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | ZipArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) Lastly, tests related to those DataPipes will also be removed or migrated to TorchData (if they do not already exist there). Differential Revision: [D33532272](https://our.internmc.facebook.com/intern/diff/D33532272) cc ezyang gchanan @VitalyFedyunin ejguan @NivekT [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Jan 12, 2022
We labeled these DataPipes as deprecated on Sep 30th, 2021 (#65827). Users should import these DataPipes from [TorchData](https://github.com/pytorch/data) to continue using them. We will be checking for any downstream library usage before landing this PR. All deprecation related to DataPipes are tracked in pytorch/data#163 DataPipes impacted by this PR: | Name | Functional API | Deprecation Date | What Happens Now | ------------- | ------------- | ------------- | ------------- | | BucketBatcher | NA | Sep 30th, 2021 | Remove (moved to TorchData) | HTTPReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | LineReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | TarArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) | ZipArchiveReader | NA | Sep 30th, 2021 | Remove (moved to TorchData) Lastly, tests related to those DataPipes will also be removed or migrated to TorchData (if they do not already exist there). Differential Revision: [D33532272](https://our.internmc.facebook.com/intern/diff/D33532272) cc ezyang gchanan @VitalyFedyunin ejguan @NivekT [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D31272794
cc @VitalyFedyunin @ejguan @NivekT