make TORCH_(CUDABLAS|CUSOLVER)_CHECK usable in custom extensions
#67161
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c28da23 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
Thanks @crcrpar for the fix. Can you also check if torch_cusolver_check and torch_cusparse_check have the same issue? |
|
@crcpar can you please add cusolver fix here too? If cusparse is problematic, let's postpone it. |
To verify that `TORCH_CUSOLVER_CHECK` is NOT available in a custom
extension.
```
======================================================================
ERROR: test_cusolver_extension (__main__.TestCppExtensionAOT)
----------------------------------------------------------------------
Traceback (most recent call last):
File "test_cpp_extensions_aot_ninja.py", line 95, in
test_cusolver_extension
from torch_test_cpp_extension import cusolver_extension
ImportError:
/home/mkozuki/ghq/github.com/crcrpar/torch-0/test/cpp_extensions/install/home/mkozuki/anaconda3/envs/torch-0/lib/python3.8/site-packages/torch_test_cpp_extension/cusolver_extension.cpython-38-x86_64-linux-gnu.so:
undefined symbol:
_ZN2at4cuda6solver23cusolverGetErrorMessageE16cusolverStatus_t
```
crcrpar
changed the title
at::cuda::blas::_cublasGetErrorEnum with C10_EXPORTTORCH_(CUDABLAS|CUSOLVER)_CHECK usable in custom extensions
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
ROCm build error is real |
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Reverting as this appears to have broken Windows CUDA jobs. See https://github.com/pytorch/pytorch/runs/4052843481?check_suite_focus=true and https://github.com/pytorch/pytorch/runs/4052717247?check_suite_focus=true for examples. |
|
This pull request has been reverted by aa16de5. To re-land this change, follow these steps. |
|
This pull request has been reverted by 5aca6b496d1f5e6402877e852e96ca7ae6d9bf8b. To re-land this change, follow these steps. |
|
Hey @crcrpar can you please resubmit this PR skipping windows test? If you can figure out what's failing with windows that'd be great, but if not, we can at least fix linux extensions (windows is not getting worse, right? It couldn't have extensions with TORCH_CUDABLAS_CHECK, and it still can't?) |
…ytorch#67161) Summary: Make `TORCH_CUDABLAS_CHECK` and `TORCH_CUSOLVER_CHECK` available in custom extensions by exporting the internal functions called by the both macros. Rel: pytorch#67073 cc xwang233 ptrblck Pull Request resolved: pytorch#67161 Reviewed By: jbschlosser Differential Revision: D31984694 Pulled By: ngimel fbshipit-source-id: 0035ecd1398078cf7d3abc23aaefda57aaa31106
|
sure, was busy a bit. |
Summary: Skip building extensions if windows following #67161 (comment) Related issue: #67073 cc ngimel xwang233 ptrblck Pull Request resolved: #67735 Reviewed By: bdhirsh Differential Revision: D32141250 Pulled By: ngimel fbshipit-source-id: 9bfdb7cf694c99f6fc8cbe9033a12429b6e4b6fe
|
This pull request has been reverted by aa16de5. To re-land this change, follow these steps. |
|
hmm, the commit mentioned above comment is the same one as in #67161 (comment) |
The bot had an issue where it was repeating revert messages; sorry about that, @crcrpar |
Make
TORCH_CUDABLAS_CHECKandTORCH_CUSOLVER_CHECKavailable in custom extensions by exporting the internal functions called by the both macros.Rel: #67073
cc @xwang233 @ptrblck