[ONNX] Add module name as PythonOp attribute #67193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1083490 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
garymm
requested changes
Oct 25, 2021
There was a problem hiding this comment.
- Could you please add a test that demonstrates the new behavior?
- The PR title is misleading. This change does not actually add the fully qualified name as an attribute, it adds the module name. I think it'd be perfectly reasonable to add the qualified name instead if that's what you want to do. Just use
__qualname__instead of__module__. That may actually be better since it seems from the docs that__module__may beNonebut__qualname__should always be set. But either way seems OK to me, just make sure the PR title matches the implementation.
| @@ -621,6 +621,20 @@ PyObject* process_outputs(PyObject *op_obj, const std::shared_ptr<PyNode>& cdata | |||
| } | |||
| } | |||
|
|
|||
| auto module_name = PyDict_GetItemString(((PyTypeObject*)op_obj)->tp_dict, "__module__"); | |||
| if (!module_name) { | |||
| return NULL; | |||
There was a problem hiding this comment.
Could you please justify the error handling code here?
It seems like most uses of this code probably won't mind if the module is missing, so making this condition return early seems like it may not be the right thing to do.
albanD
reviewed
Oct 25, 2021
shubhambhokare1
changed the title
shubhambhokare1
force-pushed
the
sbhokare/fully-qualified
branch
from
5c2e3c6 to
afc24d0
Compare
shubhambhokare1
force-pushed
the
sbhokare/fully-qualified
branch
from
afc24d0 to
1a9eb48
Compare
BowenBao
reviewed
Dec 9, 2021
BowenBao
reviewed
Dec 9, 2021
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 5, 2022
* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 21, 2022
* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 21, 2022
* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 31, 2022
* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness
garymm
pushed a commit
to garymm/pytorch
that referenced
this pull request
Feb 9, 2022
* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Feb 9, 2022
* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness
BowenBao
added a commit
that referenced
this pull request
Mar 2, 2022
…te (#67193)" * Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Mar 2, 2022
* Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: #73281 * Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D34625647 Pulled By: malfet fbshipit-source-id: b04b2a4f1dc2cf733fcf50a3b022337f80d6eead
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: #73281 * Add module name as pythonOp attr * Move to trace_post_record * Add tests * Code compactness Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D34625647 Pulled By: malfet fbshipit-source-id: b04b2a4f1dc2cf733fcf50a3b022337f80d6eead (cherry picked from commit 56e8658)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores the module name of the autograd function as attribute for a PythonOp node in the IR graph.
Before this modification:
After this modification: