[ONNX] Adds overload_name to Aten op #69378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 722a03f (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_linux_xenial_py3_6_gcc5_4_test |
Report results | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
|
@thiagocrepaldi if this is ready for review, please click "ready for review" (I'm confused because it's a draft but you're asking for review) |
thiagocrepaldi
force-pushed
the
thiagofc/update-atenop-schema
branch
2 times, most recently
from
caa73b6 to
1e55c76
Compare
thiagocrepaldi
requested review from
BowenBao and
shubhambhokare1
as code owners
thiagocrepaldi
requested review from
garymm,
jiafatom,
hwangdeyu and
BowenBao
and removed request for
BowenBao and
shubhambhokare1
garymm
requested changes
Dec 6, 2021
thiagocrepaldi
force-pushed
the
thiagofc/update-atenop-schema
branch
2 times, most recently
from
6d0c472 to
9a513bb
Compare
thiagocrepaldi
force-pushed
the
thiagofc/update-atenop-schema
branch
from
9a513bb to
6e0b286
Compare
garymm
approved these changes
Dec 7, 2021
Co-authored-by: Gary Miguel <[email protected]>
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 5, 2022
This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 21, 2022
This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 21, 2022
This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 31, 2022
This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable
BowenBao
added a commit
that referenced
this pull request
Feb 23, 2022
This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Mar 2, 2022
…)" This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Mar 2, 2022
This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: #73280 This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D34625645 Pulled By: malfet fbshipit-source-id: 37d58cfb5231833768172c122efc42edf7d8609a
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 9, 2022
Summary: Pull Request resolved: #73280 This PR adds a new attribute overload_name to the Aten node so that third party applications can implement calls to libtorch without using PyTorch source code. This is necessary because torch's torch::jit::findOperatorFor(fullname) requires a full name, including operator and overload names. ATen op was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying on torch::jit::findOperatorFor The first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D34625645 Pulled By: malfet fbshipit-source-id: 37d58cfb5231833768172c122efc42edf7d8609a (cherry picked from commit e92f091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new attribute
overload_nameto theAtennode so that third party applications can implement calls to libtorch without using PyTorch source code.This is necessary because torch's
torch::jit::findOperatorFor(fullname)requires a full name, including operator and overload names.ATenop was originally created for Caffe2, which leveraged the availability of the pytorch yaml files to create calls to the aten oeprators directly, not relying ontorch::jit::findOperatorForThe first part of the PR refactors all symbolics that create Aten ops, so that there is a single helper for this operator. Next all symbolics are updated to pass in the relevant overload name, if empty string is not applicable