[FSDP] Add always_wrap policy #73687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-varma
requested review from
mrshenli,
pritamdamania87,
zhaojuanmao,
H-Huang and
mingzhe09088
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit efa59bc (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
zhaojuanmao
approved these changes
Mar 3, 2022
|
@rohan-varma has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@rohan-varma has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@rohan-varma has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
Summary: Add a smaller helper policy that always returns True to automatically always wrap all FSDP submodules. This is the first and simplest step of providing a set of policies that allow users to seamlessly experiment with different FSDP config. More Context: #68789 Pull Request resolved: #73687 Reviewed By: jbschlosser, zhaojuanmao Differential Revision: D34625801 Pulled By: rohan-varma fbshipit-source-id: f20c951f8d62ea29b504543c93acd546247d8206
|
Hey @rohan-varma. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Add a smaller helper policy that always returns True to automatically always wrap all FSDP submodules. This is the first and simplest step of providing a set of policies that allow users to seamlessly experiment with different FSDP config. More Context: pytorch/pytorch#68789 Pull Request resolved: pytorch/pytorch#73687 Reviewed By: jbschlosser, zhaojuanmao Differential Revision: D34625801 Pulled By: rohan-varma fbshipit-source-id: f20c951f8d62ea29b504543c93acd546247d8206 (cherry picked from commit 3b0bf02bc8bb236ee09e2fa986d52bbf5231efc3)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 9, 2022
Summary: Add a smaller helper policy that always returns True to automatically always wrap all FSDP submodules. This is the first and simplest step of providing a set of policies that allow users to seamlessly experiment with different FSDP config. More Context: pytorch/pytorch#68789 Pull Request resolved: pytorch/pytorch#73687 Reviewed By: jbschlosser, zhaojuanmao Differential Revision: D34625801 Pulled By: rohan-varma fbshipit-source-id: f20c951f8d62ea29b504543c93acd546247d8206 (cherry picked from commit 3b0bf02bc8bb236ee09e2fa986d52bbf5231efc3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a smaller helper policy that always returns True to automatically always wrap all FSDP submodules. This is the first and simplest step of providing a set of policies that allow users to seamlessly experiment with different FSDP config.
More Context: #68789