[Quant][core][refactorization] Refactored qconv_unpack.cpp into an implementation file and higher level call registration and definition file (Reland #73773) #74227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ebf73d1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
approved these changes
Mar 15, 2022
… into an implementation file and higher level call registration and definition file (Reland #73773)" Summary: This a reland of #73773 -- please look at this PR directly for a summary and test plan. (cherry picked from commit 5ee42da) Differential Revision: [D34886987](https://our.internmc.facebook.com/intern/diff/D34886987) [ghstack-poisoned]
… into an implementation file and higher level call registration and definition file (Reland #73773)" Summary: This a reland of #73773 -- please look at this PR directly for a summary and test plan. (cherry picked from commit 5ee42da) Differential Revision: [D34886987](https://our.internmc.facebook.com/intern/diff/D34886987) [ghstack-poisoned]
… into an implementation file and higher level call registration and definition file (Reland #73773)" Summary: This a reland of #73773 -- please look at this PR directly for a summary and test plan. (cherry picked from commit 5ee42da) Differential Revision: [D34886987](https://our.internmc.facebook.com/intern/diff/D34886987) [ghstack-poisoned]
… into an implementation file and higher level call registration and definition file (Reland #73773)" Summary: This a reland of #73773 -- please look at this PR directly for a summary and test plan. (cherry picked from commit 5ee42da) Differential Revision: [D34886987](https://our.internmc.facebook.com/intern/diff/D34886987) [ghstack-poisoned]
… into an implementation file and higher level call registration and definition file (Reland #73773)" Summary: This a reland of #73773 -- please look at this PR directly for a summary and test plan. (cherry picked from commit 5ee42da) Differential Revision: [D34886987](https://our.internmc.facebook.com/intern/diff/D34886987) [ghstack-poisoned]
|
@dzdang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
…plementation file and higher level call registration and definition file (Reland #73773) (#74227) Summary: Pull Request resolved: #74227 This a reland of #73773 -- please look at this PR directly for a summary and test plan. (cherry picked from commit 5ee42da) Test Plan: Imported from OSS Reviewed By: jerryzh168 Differential Revision: D34886987 Pulled By: dzdang fbshipit-source-id: 4a1f4580cdc12db12af55719debf55dbcd00cac3
|
Hey @dzdang. |
|
This pull request has been reverted by 5853c8a. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
|
This pull request has been reverted by 5853c8a. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
This a reland of #73773 --
please look at this PR directly for a summary and test plan.
(cherry picked from commit 5ee42da)
Differential Revision: D34886987