[quant][fx] Only do reference moduel swapping for floating point fused modules #74231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d modules Summary: Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Facebook: see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219 Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit eeb6e07 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
jerryzh168
added a commit
that referenced
this pull request
Mar 15, 2022
…d modules Summary: Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Facebook: see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219 Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d868b36 Pull Request resolved: #74231
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
… point fused modules" Summary: Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Facebook: see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219 Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D34888290](https://our.internmc.facebook.com/intern/diff/D34888290) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 16, 2022
…d modules Summary: Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Facebook: see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219 Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 33c65f0 Pull Request resolved: #74231
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
… point fused modules" Summary: Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Facebook: see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219 Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D34888290](https://our.internmc.facebook.com/intern/diff/D34888290) [ghstack-poisoned]
This was referenced Mar 17, 2022
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
requested review from
vkuzo and
andrewor14
and removed request for
vkuzo
… point fused modules" Summary: Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Facebook: see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219 Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D34888290](https://our.internmc.facebook.com/intern/diff/D34888290) [ghstack-poisoned]
… point fused modules" Summary: Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Facebook: see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219 Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D34888290](https://our.internmc.facebook.com/intern/diff/D34888290) [ghstack-poisoned]
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
andrewor14
approved these changes
Mar 17, 2022
… point fused modules" Summary: Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Facebook: see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219 Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D34888290](https://our.internmc.facebook.com/intern/diff/D34888290) [ghstack-poisoned]
… point fused modules" Summary: Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Facebook: see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219 Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D34888290](https://our.internmc.facebook.com/intern/diff/D34888290) [ghstack-poisoned]
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
added
release notes: quantization
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
…d modules (#74231) Summary: Pull Request resolved: #74231 Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Reviewed By: andrewor14 Differential Revision: D34888290 fbshipit-source-id: a7f53368a7c17f7d1a82afaa50d14d569b4923df
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
…d modules (#74231) Summary: Pull Request resolved: #74231 Add a check to make sure the weighted modules we swap is actually a float fused module, since the reference fused module like reference version of linear - relu would have the same fused type as the floating point linear - relu (and the linear submodule will have different types) Test Plan: phabricator diff for now, can add a test case after we know exactly what the problem is Reviewed By: andrewor14 Differential Revision: D34888290 fbshipit-source-id: a7f53368a7c17f7d1a82afaa50d14d569b4923df (cherry picked from commit 458dac9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Add a check to make sure the weighted modules we swap is actually a float fused module,
since the reference fused module like reference version of linear - relu would have the same
fused type as the floating point linear - relu (and the linear submodule will have different types)
Test Plan:
phabricator diff for now, can add a test case after we know exactly what the problem is
Facebook:
see if this fixes the cogwheel test https://www.internalfb.com/diff/D34778506?dst_version_fbid=303538185178175&transaction_fbid=1332625957206219
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D34888290