-
Notifications
You must be signed in to change notification settings - Fork 24.2k
Move CompositeCompliance tests to their own TestCase #74644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is in preparation for me adding additional tests for: 1. composite compliance of autograd formulas 2. composite compliance of forward-mode AD formulas This PR also changes these tests to run on both CPU and CUDA. Previously they were just run on CPU, but it turns out there's a lot of branching on the device in composite operations in PyTorch today :/ Test Plan: - wait for tests [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 12b6b3b (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Context for reviewers: I'm beefing up composite compliance testing that was introduced as #65819 and retagging all of you as reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM then
This is in preparation for me adding additional tests for: 1. composite compliance of autograd formulas 2. composite compliance of forward-mode AD formulas This PR also changes these tests to run on both CPU and CUDA. Previously they were just run on CPU, but it turns out there's a lot of branching on the device in composite operations in PyTorch today :/ Test Plan: - wait for tests [ghstack-poisoned]
This is in preparation for me adding additional tests for: 1. composite compliance of autograd formulas 2. composite compliance of forward-mode AD formulas This PR also changes these tests to run on both CPU and CUDA. Previously they were just run on CPU, but it turns out there's a lot of branching on the device in composite operations in PyTorch today :/ Test Plan: - wait for tests [ghstack-poisoned]
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: #74644 This is in preparation for me adding additional tests for: 1. composite compliance of autograd formulas 2. composite compliance of forward-mode AD formulas This PR also changes these tests to run on both CPU and CUDA. Previously they were just run on CPU, but it turns out there's a lot of branching on the device in composite operations in PyTorch today :/ Test Plan: - wait for tests Reviewed By: albanD Differential Revision: D35186861 Pulled By: zou3519 fbshipit-source-id: d974592a7547f71ef26ff0740bf453f7d335d55a
Stack from ghstack:
This is in preparation for me adding additional tests for:
This PR also changes these tests to run on both CPU and CUDA. Previously
they were just run on CPU, but it turns out there's a lot of branching
on the device in composite operations in PyTorch today :/
Test Plan:
Differential Revision: D35186861