Extending _get_bytecode_version to support flatbuffers format #75021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extending `_get_bytecode_version` to support flatbuffers. Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)! [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d00bb33 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
cla signed
oncall: jit
Closed
pavithranrao
added a commit
that referenced
this pull request
Mar 31, 2022
Extending `_get_bytecode_version` to support flatbuffers. Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)! ghstack-source-id: 152699457 Pull Request resolved: #75021
…mat" Extending `_get_bytecode_version` to support flatbuffers. Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)! [ghstack-poisoned]
pavithranrao
added a commit
that referenced
this pull request
Mar 31, 2022
Pull Request resolved: #75021 Extending `_get_bytecode_version` to support flatbuffers. ghstack-source-id: 152701972 Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)!
…mat" Extending `_get_bytecode_version` to support flatbuffers. Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)! [ghstack-poisoned]
pavithranrao
added a commit
that referenced
this pull request
Mar 31, 2022
Pull Request resolved: #75021 Extending `_get_bytecode_version` to support flatbuffers. ghstack-source-id: 152721022 Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)!
…mat" Extending `_get_bytecode_version` to support flatbuffers. Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)! [ghstack-poisoned]
pavithranrao
added a commit
that referenced
this pull request
Mar 31, 2022
Pull Request resolved: #75021 Extending `_get_bytecode_version` to support flatbuffers. ghstack-source-id: 152746186 Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)!
…mat" Extending `_get_bytecode_version` to support flatbuffers. Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)! [ghstack-poisoned]
…mat" Extending `_get_bytecode_version` to support flatbuffers. Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)! [ghstack-poisoned]
…mat" Extending `_get_bytecode_version` to support flatbuffers. Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)! [ghstack-poisoned]
pavithranrao
added a commit
that referenced
this pull request
Apr 1, 2022
Pull Request resolved: #75021 Extending `_get_bytecode_version` to support flatbuffers. ghstack-source-id: 152771695 Differential Revision: [D34900498](https://our.internmc.facebook.com/intern/diff/D34900498/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34900498/)!
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
Summary: Pull Request resolved: #75021 Extending `_get_bytecode_version` to support flatbuffers. ghstack-source-id: 152771695 (Note: this ignores all push blocking failures!) Test Plan: ``` ~/fbsource/xplat] cd ~/fbsource/xplat/ && buck test //xplat/caffe2:test_lite_interpreter Building: finished in 0.8 sec (100%) 327/327 jobs, 0/327 updated Total time: 0.9 sec Testing: finished in 06:59.5 min (85 PASS/0 FAIL) BUILD SUCCEEDED RESULTS FOR //xplat/caffe2:test_lite_interpreter PASS 412.3s 85 Passed 0 Skipped 0 Failed //xplat/caffe2:test_lite_interpreter TESTS PASSED ``` Reviewed By: iseeyuan Differential Revision: D34900498 fbshipit-source-id: 65743076d43a933c5381ec128d0268f22c0a8441
|
Hey @pavithranrao. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Extending
_get_bytecode_versionto support flatbuffers.Differential Revision: D34900498
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!