Dedupe no parsing __torch_function__ handler #75159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now there is truly only one way to call __torch_function__ and that is via handle_torch_function_no_python_arg_parser Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
This was referenced Apr 3, 2022
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 433f675 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Now there is truly only one way to call __torch_function__ and that is via handle_torch_function_no_python_arg_parser Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
Now there is truly only one way to call __torch_function__ and that is via handle_torch_function_no_python_arg_parser Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
peterbell10
reviewed
Apr 3, 2022
Now there is truly only one way to call __torch_function__ and that is via handle_torch_function_no_python_arg_parser Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
peterbell10
approved these changes
Apr 3, 2022
zou3519
approved these changes
Apr 4, 2022
|
@pytorchbot merge this |
|
Hey @ezyang. |
ezyang
added
release notes: composability
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
Summary: Now there is truly only one way to call __torch_function__ and that is via handle_torch_function_no_python_arg_parser Signed-off-by: Edward Z. Yang <ezyangfb.com> Pull Request resolved: #75159 Approved by: https://github.com/zou3519 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e3848d75dfd41909d1a2885bf272d2588b25150f Reviewed By: atalman Differential Revision: D35359959 Pulled By: ezyang fbshipit-source-id: e9a4c01200d24a8ac486b1738b30cbdd6c1e91bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Now there is truly only one way to call torch_function
and that is via handle_torch_function_no_python_arg_parser
Signed-off-by: Edward Z. Yang [email protected]