Skip to content

Add quantized::softmax to fc list #75254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add quantized::softmax to fc list #75254

wants to merge 1 commit into from

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Apr 5, 2022 •
edited
Loading

Hoping to fix regression from https://hud.pytorch.org/minihud#1bcae0d10e1c4eddf07f9e60ced9b4f3c2c04b1f

Adding quantized::softmax to list until 4/15/22.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 142a5b0 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@janeyx99 janeyx99 added the oncall: mobile Related to mobile support, including iOS and Android label Apr 5, 2022
albanD
albanD approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janeyx99
Copy link
Contributor Author

janeyx99 commented Apr 5, 2022

@pytorchbot merge this pls!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Hey @janeyx99.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 7, 2022
@janeyx99 @facebook-github-bot
Add quantized::softmax to fc list (#75254)
b4afd1c 
Summary:
Hoping to fix regression from https://hud.pytorch.org/minihud#1bcae0d10e1c4eddf07f9e60ced9b4f3c2c04b1f

Adding quantized::softmax to list until 4/15/22.

Pull Request resolved: #75254
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/79cae53fdd416383dfe8ef928ba72c879659dd2e

Reviewed By: b0noI

Differential Revision: D35404312

Pulled By: janeyx99

fbshipit-source-id: fa48e57b8bbea951302d77dfaca07d7a911f5868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
cla signed oncall: mobile Related to mobile support, including iOS and Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janeyx99 @facebook-github-bot @albanD