Skip to content

[reland] [complex] conv1d #75310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kshitij12345
Copy link
Collaborator

Reland : #75013

Reference: #71108

@kshitij12345 kshitij12345 added module: complex Related to complex number support in PyTorch ciflow/slow labels Apr 6, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 6, 2022

We have recently simplified the CIFlow labels and ciflow/slow is no longer in use.
You can use any of the following

  • ciflow/trunk (.github/workflowss/trunk.yml): all jobs we run per-commit on master
  • ciflow/periodic (.github/workflows/periodic.yml): all jobs we run periodically on master
  • ciflow/all: trunk + periodic; all jobs we run in master CI
  • ciflow/nightly (.github/workflows/nightly.yml): all jobs we run nightly
  • ciflow/binaries: all binary build and upload jobs

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 6, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit b29b58a (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented Apr 6, 2022

@suo I am not sure why a lot of CI are failing with artifact.zip not found (master doesn't have such failures and changes in the PR don't touch CI or build).

Could you please take a look. Thank you!

Looks like it got fixed rebase with latest master.

@kshitij12345 kshitij12345 marked this pull request as ready for review April 6, 2022 12:44
@kshitij12345 kshitij12345 requested a review from anjali411 April 6, 2022 12:44
Copy link
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pytorchbot merge this please

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 6, 2022

+1

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Hey @kshitij12345.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 7, 2022
Summary:
Reland : #75013

Reference: #71108

Pull Request resolved: #75310
Approved by: https://github.com/anjali411

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/706b9e8b8d8b17cc33f74636bf520a5a53e4d386

Reviewed By: b0noI

Differential Revision: D35437863

fbshipit-source-id: 068ca2191e3be2abac4082bae3b234b21eb1ac0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed module: complex Related to complex number support in PyTorch open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants