Skip to content

[Distributed tests] Add skip for odd world_size condition #76136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jaglinux
Copy link
Contributor

As per #74995, the tests
needs to be skipped for odd WORLD_SIZE

Signed-off-by: Jagadish Krishnamoorthy [email protected]

Fixes #74995

As per pytorch#74995, the tests
needs to be skipped for odd WORLD_SIZE

Signed-off-by: Jagadish Krishnamoorthy <[email protected]>
Signed-off-by: Jagadish Krishnamoorthy <[email protected]>
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 20, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit b17a5ce (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Apr 20, 2022
@jaglinux
Copy link
Contributor Author

@jaglinux jaglinux changed the title Origin/odd world size [Distributed tests] Add skip for odd world_size condition Apr 20, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 24, 2022

We have recently simplified the CIFlow labels and ci/master is no longer in use.
You can use any of the following

  • ciflow/trunk (.github/workflows/trunk.yml): all jobs we run per-commit on master
  • ciflow/periodic (.github/workflows/periodic.yml): all jobs we run periodically on master
  • ciflow/all: trunk + periodic; all jobs we run in master CI
  • ciflow/android (.github/workflows/run_android_tests.yml): android build and test
  • ciflow/nightly (.github/workflows/nightly.yml): all jobs we run nightly
  • ciflow/binaries: all binary build and upload jobs
  • ciflow/binaries_conda: binary build and upload job for conda
  • ciflow/binaries_libtorch: binary build and upload job for libtorch
  • ciflow/binaries_wheel: binary build and upload job for wheel

Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pytorchbot merge this please

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 24, 2022

+1

@github-actions
Copy link
Contributor

Hey @jaglinux.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request Apr 25, 2022
As per pytorch#74995, the tests
needs to be skipped for odd WORLD_SIZE

Signed-off-by: Jagadish Krishnamoorthy <[email protected]>

Fixes pytorch#74995

Pull Request resolved: pytorch#76136
Approved by: https://github.com/kumpera, https://github.com/wayi1
facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
Summary:
As per #74995, the tests
needs to be skipped for odd WORLD_SIZE

Signed-off-by: Jagadish Krishnamoorthy <[email protected]>

Fixes #74995

Pull Request resolved: #76136
Approved by: https://github.com/kumpera, https://github.com/wayi1

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6ca8272d46a67b56b1cb65bb551bcbf5709f005b

Reviewed By: seemethere

Differential Revision: D35902479

Pulled By: seemethere

fbshipit-source-id: 191a00018e46296b73319a8a0ddc4467dc4764bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_post_localSGD_optimizer_parity_with_hierarchical_sgd error
6 participants