-
Notifications
You must be signed in to change notification settings - Fork 24.2k
[DataPipe] Refactor 'mux' to have buffer as an instance variable #77775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful links
❌ 1 New Failures, 1 PendingAs of commit 74964b2 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
…riable" This allows the buffer to be saved by snapshotting if needed. [ghstack-poisoned]
…nstance (self)" This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
…nstance (self)" This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
…riable" This allows the buffer to be saved by snapshotting if needed. [ghstack-poisoned]
…nstance (self)" This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
…riable" This allows the buffer to be saved by snapshotting if needed. [ghstack-poisoned]
…riable" This allows the buffer to be saved by snapshotting if needed. [ghstack-poisoned]
…riable" This allows the buffer to be saved by snapshotting if needed. [ghstack-poisoned]
…nstance (self)" This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Could you please import it into Phabricator to verify nothing breaks in TorchData? You can still land PR from OSS.
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…nstance (self)" This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly Differential Revision: [D36519522](https://our.internmc.facebook.com/intern/diff/D36519522) [ghstack-poisoned]
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly Differential Revision: [D36519522](https://our.internmc.facebook.com/intern/diff/D36519522) [ghstack-poisoned]
@pytorchbot merge |
Summary: Pull Request resolved: #388 This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance. This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 Note that the CI is expected to fail until that PR goes into nightly Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D36519522 Pulled By: NivekT fbshipit-source-id: cc3616e1941777771e8c8b5cd26953f2f6ed48c8
) Summary: Pull Request resolved: #77775 Approved by: https://github.com/ejguan Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b4a6730ce1d403e4fc7c20c82dcb5abe6bb5e472 Reviewed By: george-qi, seemethere, ejguan Differential Revision: D36521038 Pulled By: NivekT fbshipit-source-id: 2389f0d122e5b735dc7684a703861a789115348e
Stack from ghstack:
This allows the buffer to be saved by snapshotting if needed.
Differential Revision: D36521038