Skip to content

[DataPipe] Refactor 'mux' to have buffer as an instance variable #77775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented May 18, 2022

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 18, 2022

🔗 Helpful links

❌ 1 New Failures, 1 Pending

As of commit 74964b2 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/1)

Step: "Download build artifacts" (full log | diagnosis details | 🔁 rerun)

2022-05-19T20:43:03.6685879Z ##[error]No files ...ath: test/**/*.xml. No artifacts will be uploaded.
2022-05-19T20:43:03.4652588Z   retention-days: 14
2022-05-19T20:43:03.4653067Z   if-no-files-found: error
2022-05-19T20:43:03.4653546Z   path: test/**/*.xml
2022-05-19T20:43:03.4653954Z env:
2022-05-19T20:43:03.4654327Z   IN_CI: 1
2022-05-19T20:43:03.4654707Z   IS_GHA: 1
2022-05-19T20:43:03.4655148Z   GIT_DEFAULT_BRANCH: master
2022-05-19T20:43:03.4655886Z   DOCKER_HOST: unix:///run/user/1502/docker.sock
2022-05-19T20:43:03.4656757Z   GPU_FLAG: --device=/dev/mem --device=/dev/kfd --device=/dev/dri/renderD128 --device=/dev/dri/renderD129 --group-add video --group-add daemon
2022-05-19T20:43:03.4657667Z ##[endgroup]
2022-05-19T20:43:03.6685879Z ##[error]No files were found with the provided path: test/**/*.xml. No artifacts will be uploaded.
2022-05-19T20:43:03.6749794Z ##[group]Run set -x
2022-05-19T20:43:03.6750305Z �[36;1mset -x�[0m
2022-05-19T20:43:03.6750869Z �[36;1mpython3 -m pip install -r requirements.txt�[0m
2022-05-19T20:43:03.6751528Z �[36;1mpython3 -m pip install boto3==1.19.12�[0m
2022-05-19T20:43:03.6752289Z �[36;1mpython3 -m tools.stats.print_test_stats --upload-to-s3 --compare-with-s3 test�[0m
2022-05-19T20:43:03.6791468Z shell: /bin/bash --noprofile --norc -e -o pipefail {0}
2022-05-19T20:43:03.6792018Z env:
2022-05-19T20:43:03.6792425Z   IN_CI: 1
2022-05-19T20:43:03.6792847Z   IS_GHA: 1
2022-05-19T20:43:03.6793320Z   GIT_DEFAULT_BRANCH: master

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@NivekT NivekT requested review from ejguan and VitalyFedyunin and removed request for ejguan May 18, 2022 19:50
@NivekT NivekT added module: data torch.utils.data release notes: dataloader release notes category topic: improvements topic category labels May 18, 2022
…riable"


This allows the buffer to be saved by snapshotting if needed.

[ghstack-poisoned]
NivekT added a commit to pytorch/data that referenced this pull request May 18, 2022
…nstance (self)"


This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly


[ghstack-poisoned]
NivekT added a commit to pytorch/data that referenced this pull request May 18, 2022
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly


[ghstack-poisoned]
NivekT added a commit to pytorch/data that referenced this pull request May 18, 2022
…nstance (self)"


This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly


[ghstack-poisoned]
NivekT added a commit to pytorch/data that referenced this pull request May 18, 2022
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly


[ghstack-poisoned]
…riable"


This allows the buffer to be saved by snapshotting if needed.

[ghstack-poisoned]
NivekT added a commit to pytorch/data that referenced this pull request May 19, 2022
…nstance (self)"


This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly


[ghstack-poisoned]
NivekT added a commit to pytorch/data that referenced this pull request May 19, 2022
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly


[ghstack-poisoned]
@NivekT NivekT added the topic: not user facing topic category label May 19, 2022
NivekT added 3 commits May 19, 2022 10:57
…riable"


This allows the buffer to be saved by snapshotting if needed.

[ghstack-poisoned]
…riable"


This allows the buffer to be saved by snapshotting if needed.

[ghstack-poisoned]
…riable"


This allows the buffer to be saved by snapshotting if needed.

[ghstack-poisoned]
NivekT added a commit to pytorch/data that referenced this pull request May 19, 2022
…nstance (self)"


This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly


[ghstack-poisoned]
NivekT added a commit to pytorch/data that referenced this pull request May 19, 2022
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly


[ghstack-poisoned]
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Could you please import it into Phabricator to verify nothing breaks in TorchData? You can still land PR from OSS.

@NivekT
Copy link
Contributor Author

NivekT commented May 19, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

NivekT added a commit to pytorch/data that referenced this pull request May 19, 2022
…nstance (self)"


This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly

Differential Revision: [D36519522](https://our.internmc.facebook.com/intern/diff/D36519522)

[ghstack-poisoned]
NivekT added a commit to pytorch/data that referenced this pull request May 19, 2022
This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775 

Note that the CI is expected to fail until that PR goes into nightly

Differential Revision: [D36519522](https://our.internmc.facebook.com/intern/diff/D36519522)

[ghstack-poisoned]
@NivekT
Copy link
Contributor Author

NivekT commented May 19, 2022

@pytorchbot merge

facebook-github-bot pushed a commit to pytorch/data that referenced this pull request May 19, 2022
Summary:
Pull Request resolved: #388

This PR impacts `ParagraphAggregator` and `IterKeyZipper` as they previously have their buffer with the iterator rather than the instance.

This should be landed along with pytorch/pytorch#76999 and pytorch/pytorch#77775

Note that the CI is expected to fail until that PR goes into nightly

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D36519522

Pulled By: NivekT

fbshipit-source-id: cc3616e1941777771e8c8b5cd26953f2f6ed48c8
facebook-github-bot pushed a commit that referenced this pull request May 20, 2022
)

Summary:
Pull Request resolved: #77775

Approved by: https://github.com/ejguan

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b4a6730ce1d403e4fc7c20c82dcb5abe6bb5e472

Reviewed By: george-qi, seemethere, ejguan

Differential Revision: D36521038

Pulled By: NivekT

fbshipit-source-id: 2389f0d122e5b735dc7684a703861a789115348e
@facebook-github-bot facebook-github-bot deleted the gh/nivekt/52/head branch May 23, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants