emplace(key, value) rather than emplace(std::make_pair(key, value));

[guodongxiaren]

emplace(key, value) is better than emplace(std::make_pair(key, value));

Reference:
Effective modern C++ item 42: Consider emplacement instead of insertion.

[facebook-github-bot]

Hi @guodongxiaren!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

🔗 Helpful links

• 🧪  See artifacts and rendered test results at hud.pytorch.org/pr/81614
• ✖️ Python docs build was skipped
• ✖️ C++ docs build was skipped
• ❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit e1f82ce (more details on the Dr. CI page):

Expand to see more

---

Commit e1f82ce was recently pushed. Waiting for builds...

---

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[guodongxiaren]

please review this pull request. Thanks. @rohan-varma @BowenBao @pritamdamania @H-Huang @mrshenli @awgu @shubhambhokare1 @mingzhe09088 @zhaojuanmao

[github-actions]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[facebook-github-bot]

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: guodongxiaren / name: 果冻虾仁 (e1f82ce)

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/81614

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 945590d:

The following jobs have failed:

• lintrunner

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[guodongxiaren]

Please approving workflow runs from my forks. Thanks.

@rohan-varma @BowenBao @pritamdamania @H-Huang @mrshenli @awgu @zhaojuanmao