Fix Dockerfile conda install error for some shells #92702
Conversation
The issue was first solved in [#91371 (comment)] for CI/CD, but the main Dockerfile in the repo root still has this issue for people trying to test build custom image manually. Without it the build fails at installing miniconda ``` #14 3.802 Preparing transaction: ...working... done #14 4.087 Executing transaction: ...working... done #14 5.713 /root/miniconda.sh: 438: /root/miniconda.sh: [[: not found #14 5.713 #14 5.713 Installing * environment... #14 5.713 #14 5.714 /root/miniconda.sh: 444: /root/miniconda.sh: [[: not found #14 6.050 #14 6.050 CondaFileIOError: '/opt/conda/pkgs/envs/*/env.txt'. [Errno 2] No such file or directory: '/opt/conda/pkgs/envs/*/env.txt' #14 6.050 ``` With the modification, locally tested build successfully with `make -f ./docker.Makefile` as instructed in the README
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92702
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit b85f3e5: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
H-Huang
requested review from
malfet and
seemethere
and removed request for
malfet
H-Huang
added
the
triaged
|
Thanks for this! |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f "Docker builds are green, the rest is irrelevant" |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This pins setup-buildx-action version. Our Docker builds where fixed by: #92702 on Jan 25,26 However setup-builder-action update on Jan 27 broke these builds again. This PR pins version of setup-buildx-action and fixes Docker builds for nightly. Pull Request resolved: #94734 Approved by: https://github.com/jeanschmidt
The issue was first solved in [/pull/91371] for CI/CD, but the main Dockerfile in the repo root still has this issue for people trying to test build custom image manually.
Without it the build fails at installing miniconda
With the modification, locally tested build successfully with
make -f ./docker.Makefileas instructed in the README